Skip to content

Missing version string if not building from git clone #405

@TheBill2001

Description

@TheBill2001

Description

Currently, CMake fetch version string from git tag. This work if we are building directly from a cloned directory. However, if we build from the source package from the release page, the version string becomes empty since there is no git tree in it.

This does not cause the build to fail, nor does it affect the function of the program. The version string simply shows up as empty in the terminal.

In the AUR packaging, as a workaround, I simply create the version file using sed after the configuring step:

sed "s/@GIT_VERSION@/${VERSION}/g" "src/version.h.in" > "src/version.h"

This affect v3.0.0, and probably older version, too. I come to check, but I must have forgotten to report it before.

On which OS does the problem happen?

Linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions