Closes #30. Fixed a bug in which transactions are not rolled back on Dispose when using EntityFrameworkCore.

Noah Potash · Noah Potash · commit 5c175c1f2da7 · 2017-02-04T08:51:25.000-05:00
diff --git a/Source/MySql.Data/project.json b/Source/MySql.Data/project.json
@@ -1,5 +1,5 @@
 {
-  "version": "6.9.813",
+  "version": "6.9.814",
   "description": "MySQL client library targeting netstandard 1.3",
   "authors": [ "Oracle", "SapientGuardian", "ebyte23" ],
   "buildOptions": {
diff --git a/Source/MySql.Data/transaction.cs b/Source/MySql.Data/transaction.cs
@@ -88,8 +88,8 @@ public void Dispose()
       GC.SuppressFinalize(this);
     }
 
-    internal void Dispose(bool disposing)
-    {
+    protected override void Dispose(bool disposing)
+        {
       if (disposing)
       {
         if ((conn != null && conn.State == ConnectionState.Open || conn.SoftClosed) && open)

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": "6.9.813",`
	`2`	`+ "version": "6.9.814",`
`3`	`3`	`"description": "MySQL client library targeting netstandard 1.3",`
`4`	`4`	`"authors": [ "Oracle", "SapientGuardian", "ebyte23" ],`
`5`	`5`	`"buildOptions": {`
Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,8 @@ public void Dispose()`
`88`	`88`	`GC.SuppressFinalize(this);`
`89`	`89`	`}`
`90`	`90`
`91`		`- internal void Dispose(bool disposing)`
`92`		`- {`
	`91`	`+ protected override void Dispose(bool disposing)`
	`92`	`+ {`
`93`	`93`	`if (disposing)`
`94`	`94`	`{`
`95`	`95`	`if ((conn != null && conn.State == ConnectionState.Open \|\| conn.SoftClosed) && open)`