Skip to content
This repository was archived by the owner on Aug 27, 2024. It is now read-only.

Commit 20904e8

Browse files
author
Eugene Mosunov
committed
Remove TypeHinting in Repository to make compatibility with other DB
1 parent 809494d commit 20904e8

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

phpcs.xml

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
<rule ref="Generic.Commenting.DocComment.SpacingBeforeTags" />
1919
<rule ref="MySource.Commenting.FunctionComment.InvalidReturn" />
2020
<rule ref="MySource.Commenting.FunctionComment.MissingParamComment" />
21-
<rule ref="MySource.Commenting.FunctionComment.TypeHintMissing" />
21+
<rule ref="MySource.Commenting.FunctionComment.TypeHintMissing">
22+
<exclude-pattern>/src/Repositories/Repository.php</exclude-pattern>
23+
</rule>
2224
<rule ref="Generic.Arrays.DisallowLongArraySyntax" />
2325
<rule ref="Generic.Classes.DuplicateClassName" />
2426
<rule ref="Generic.CodeAnalysis.EmptyStatement" />

src/Repositories/Repository.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ protected function toCursorResult(CursorRequest $cursor, $query): CursorResult
223223
*
224224
* @return Builder
225225
*/
226-
protected function query(): Builder
226+
protected function query()
227227
{
228228
return $this->model->query();
229229
}
@@ -426,7 +426,7 @@ public function findWhere(array $fieldValues): ?Model
426426
*
427427
* @throws BadCriteriaException when any criterion is not valid
428428
*/
429-
protected function getNestedWhereConditions(QueryBuilder $builder, array $criteria): QueryBuilder
429+
protected function getNestedWhereConditions($builder, array $criteria)
430430
{
431431
$subQuery = $builder->forNestedWhere();
432432
foreach ($criteria as $key => $criterionData) {

0 commit comments

Comments
 (0)