Add views and entities for SAT-21596 (#2465)

Author: qcjames53

airgun/entities/contentcredential.py

@@ -1,11 +1,13 @@
 from wait_for import wait_for
 
 from airgun.entities.base import BaseEntity
+from airgun.exceptions import DisabledWidgetError
 from airgun.navigation import NavigateStepWithWait as NavigateStep, navigator
+from airgun.views.common import TableRowKebabMenu
 from airgun.views.contentcredential import (
-    ContentCredentialCreateView,
     ContentCredentialEditView,
     ContentCredentialsTableView,
+    CreateContentCredentialModal,
     DeleteContentCredentialModal,
 )
 from airgun.views.product import ProductEditView
@@ -16,15 +18,60 @@ class ContentCredentialEntity(BaseEntity):
     endpoint_path = '/labs/content_credentials'
 
     def create(self, values):
-        """Create new content credentials entity."""
-        raise NotImplementedError(
-            'Content Credential create is not yet implemented in the React UI'
+        """Create new content credentials entity via modal.
+
+        Args:
+            values (dict): Should contain:
+                - name (str): Name of the credential
+                - content_type (str): Type - 'GPG Key' or 'Certificate'
+                - content (str): The GPG key or certificate content
+
+        Raises:
+            DisabledWidgetError: If the create button is disabled due to missing required fields
+        """
+        view = self.navigate_to(self, 'All')
+        view.create_button.click()
+        modal = CreateContentCredentialModal(self.browser)
+        modal.wait_displayed()
+        modal.fill(
+            {
+                'name_input': values.get('name', ''),
+                'content_type': values.get('content_type', ''),
+                'content_text_box': values.get('content', ''),
+            }
+        )
+        if modal.create_button.disabled:
+            raise DisabledWidgetError(
+                'Create button is disabled. Required fields (name and content) must be filled.'
+            )
+        modal.create_button.click()
+        wait_for(
+            lambda: not modal.is_displayed,
+            timeout=30,
+            delay=0.5,
+            handle_exception=True,
+            message='Waiting for create modal to close',
+        )
+        wait_for(
+            lambda: view.table.row(name=values['name']),
+            timeout=30,
+            delay=0.5,
+            handle_exception=True,
+            message=f'Waiting for credential "{values["name"]}" to appear in table',
         )
 
     def delete(self, entity_name):
-        """Delete existing content credentials entity via kebab menu."""
-        view = self.navigate_to(self, 'Edit', entity_name=entity_name)
-        view.actions.item_select('Delete')
+        """Delete existing content credentials entity via table row kebab menu."""
+        view = self.navigate_to(self, 'All')
+        view.search(entity_name)
+        wait_for(
+            lambda: view.table.row(name=entity_name),
+            timeout=30,
+            delay=0.5,
+            handle_exception=True,
+            message=f'Waiting for credential "{entity_name}" row to appear',
+        )
+        TableRowKebabMenu(parent=view.table.row(name=entity_name)).item_select('Delete')
         modal = DeleteContentCredentialModal(self.browser)
         modal.wait_displayed()
         modal.confirm_delete.click()
@@ -108,18 +155,6 @@ def step(self, *args, **kwargs):
         self.view.menu.select('Lab Features', 'Content Credentials')
 
 
-@navigator.register(ContentCredentialEntity, 'New')
-class AddNewContentCredential(NavigateStep):
-    """Navigate to Create Content Credential page (stub)."""
-
-    VIEW = ContentCredentialCreateView
-
-    def step(self, *args, **kwargs):
-        raise NotImplementedError(
-            'Content Credential create is not yet implemented in the React UI'
-        )
-
-
 @navigator.register(ContentCredentialEntity, 'Edit')
 class EditContentCredential(NavigateStep):
     """Navigate to Content Credential details screen.

airgun/views/contentcredential.py

@@ -1,6 +1,7 @@
 from widgetastic.utils import ParametrizedLocator
-from widgetastic.widget import Text, View
+from widgetastic.widget import Text, TextInput, View
 from widgetastic_patternfly import Tab
+from widgetastic_patternfly5.components.forms.form_select import FormSelect
 from widgetastic_patternfly5.ouia import (
     BreadCrumb as PF5OUIABreadCrumb,
     Button as PF5OUIAButton,
@@ -11,13 +12,14 @@
 )
 
 from airgun.views.common import BaseLoggedInView, SearchableViewMixinPF4
-from airgun.widgets import PF5SpacedListItem
+from airgun.widgets import PF5EditableSpacedListItem, PF5SpacedListItem
 
 
 class ContentCredentialsTableView(BaseLoggedInView, SearchableViewMixinPF4):
     """PF5 list page for Content Credentials at /labs/content_credentials."""
 
     title = Text('//h1[normalize-space(.)="Content Credentials"]')
+    create_button = PF5OUIAButton('action-buttons-create')
     table = PF5OUIATable(
         component_id='content-credentials-table',
         column_widgets={
@@ -27,21 +29,34 @@ class ContentCredentialsTableView(BaseLoggedInView, SearchableViewMixinPF4):
 
     @property
     def is_displayed(self):
-        return self.title.is_displayed and self.table.is_displayed
+        return (
+            self.title.is_displayed and self.table.is_displayed and self.create_button.is_displayed
+        )
+
+
+class CreateContentCredentialModal(PF5OUIAModal):
+    """PF5 confirmation modal for creating a Content Credential."""
 
+    OUIA_ID = 'create-content-credential-modal'
 
-class ContentCredentialCreateView(BaseLoggedInView):
-    # Not yet implemented in React UI
-    pass
+    name_input = PF5OUIATextInput('create-content-credential-name-input')
+    content_type = FormSelect(locator='.//select[@id="content_type"]')
+    content_text_box = TextInput(locator='.//textarea[@aria-label="content"]')
+    create_button = PF5OUIAButton('create-content-credential-create-button')
+    cancel_button = PF5OUIAButton('create-content-credential-cancel-button')
+
+    @property
+    def is_displayed(self):
+        return self.name_input.is_displayed
 
 
 class DeleteContentCredentialModal(PF5OUIAModal):
     """PF5 confirmation modal for deleting a Content Credential."""
 
     OUIA_ID = 'delete-content-credential-modal'
 
-    confirm_delete = PF5OUIAButton('delete-confirm-button')
-    cancel = PF5OUIAButton('delete-cancel-button')
+    confirm_delete = PF5OUIAButton('delete-content-credential-delete-button')
+    cancel = PF5OUIAButton('delete-content-credential-cancel-button')
 
     @property
     def is_displayed(self):
@@ -66,7 +81,7 @@ def is_displayed(self):
     class details(Tab):
         TAB_LOCATOR = ParametrizedLocator('//*[@data-ouia-component-id="routed-tabs-tab-details"]')
 
-        name = PF5SpacedListItem(label='Name')
+        name = PF5EditableSpacedListItem(label='Name')
         content_type = PF5SpacedListItem(label='Type')
         content = PF5SpacedListItem(label='Content')
         upload_file = PF5OUIAButton('upload-file-button')

airgun/widgets.py

@@ -3288,3 +3288,54 @@ def __locator__(self):
     def read(self):
         """Return the text content of the ``<dd>`` element."""
         return self.browser.text(self).strip()
+
+
+class PF5EditableSpacedListItem(PF5SpacedListItem):
+    """An editable field in a PF5 description list with inline editing.
+
+    Extends PF5SpacedListItem to support editing via an edit button, text input, and submit button.
+
+    Usage::
+
+        name = PF5EditableSpacedListItem(label='Name')
+    """
+
+    def fill(self, value):
+        """Edit the field value.
+
+        Args:
+            value: The new value to set
+
+        Returns:
+            bool: True if the value was changed, False otherwise
+        """
+        current_value = self.read()
+        if current_value == value:
+            return False
+
+        # Click the edit button for this field
+        # The edit button has OUIA component-id like 'edit-button-name' where 'name' is the lowercase label
+        edit_button_id = f'edit-button-{self.label.lower()}'
+        edit_button = PF5OUIAButton(self, component_id=edit_button_id)
+        edit_button.click()
+
+        # Wait for the text input to appear and fill it
+        # The input field has an OUIA component-id, but it's auto-generated
+        # We'll locate it by being within the same dd element
+        text_input_locator = './/input[@type="text"]'
+        text_input = TextInput(self, locator=text_input_locator)
+        text_input.fill(value)
+
+        # Click the submit button
+        submit_button_id = f'submit-button-{self.label.lower()}'
+        submit_button = PF5OUIAButton(self, component_id=submit_button_id)
+        submit_button.click()
+
+        # Wait for edit mode to close (edit button reappears)
+        wait_for(
+            lambda: edit_button.is_displayed,
+            timeout=10,
+            delay=0.5,
+        )
+
+        return True