Skip to content

Commit 3c5e12b

Browse files
authored
[6.19.z] Convert docker private registry test to positive scenario (#22219)
Convert docker private registry test to positive scenario rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
1 parent 983f2f0 commit 3c5e12b

1 file changed

Lines changed: 12 additions & 15 deletions

File tree

tests/foreman/api/test_repository.py

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1727,31 +1727,28 @@ def test_negative_synchronize_private_registry_wrong_repo(self, repo_options, re
17271727
),
17281728
indirect=True,
17291729
)
1730-
def test_negative_synchronize_private_registry_no_passwd(
1730+
def test_positive_create_docker_repo_with_private_registry_no_passwd(
17311731
self, repo_options, module_product, target_sat
17321732
):
1733-
"""Create and try to sync a Docker-type repository from a private
1734-
registry providing empty password and the sync must fail with
1735-
reasonable error message.
1733+
"""Create a Docker-type repository from a private registry
1734+
with username but without password.
17361735
1737-
:id: 86bde2f1-4761-4045-aa54-c7be7715cd3a
1736+
:id: 9e4e2139-a990-4e76-a1db-a7be3fd3654b
17381737
17391738
:parametrized: yes
17401739
1741-
:expectedresults: A repository is created with a private Docker \
1742-
repository and sync fails with reasonable error message.
1740+
:expectedresults: A Docker repository is created successfully
1741+
with a private registry using username but no password.
17431742
17441743
:customerscenario: true
17451744
1746-
:BZ: 1475121, 1580510
1747-
17481745
"""
1749-
with pytest.raises(
1750-
HTTPError,
1751-
match='422 Client Error: Unprocessable Content for url: '
1752-
f'{target_sat.url}/katello/api/v2/repositories',
1753-
):
1754-
target_sat.api.Repository(**repo_options).create()
1746+
repo = target_sat.api.Repository(**repo_options).create()
1747+
assert repo.id
1748+
assert repo.content_type == 'docker'
1749+
assert repo.docker_upstream_name == settings.docker.private_registry_name
1750+
assert repo.upstream_username == settings.docker.private_registry_username
1751+
assert repo.url == settings.docker.private_registry_url
17551752

17561753
@pytest.mark.upgrade
17571754
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)