cherrypick : Modifications in CLI and UI Libvirt CR to resolve key error

Author: nacoool

pytest_fixtures/component/provision_pxe.py

@@ -149,6 +149,7 @@ def module_provisioning_sat(
     It calls a workflow using broker to set up the network and to run satellite-installer.
     It uses the artifacts from the workflow to create all the necessary Satellite entities
     that are later used by the tests.
+    For IPv4, it clears DHCP leases and restarts dhcpd to ensure provisioning can obtain addresses.
     """
     provisioning_type = getattr(request, 'param', '')
     sat = module_target_sat
@@ -210,6 +211,9 @@ def module_provisioning_sat(
         remote_execution_proxy=[module_provisioning_capsule.id],
         domain=[domain.id],
     ).create()
+    if sat.network_type == NetworkType.IPV4:
+        assert sat.execute('cat /dev/null > /var/lib/dhcpd/dhcpd.leases').status == 0
+        assert sat.execute('systemctl restart dhcpd').status == 0
     return Box(sat=sat, domain=domain, subnet=subnet, provisioning_type=provisioning_type)
 
 

tests/foreman/cli/test_computeresource_libvirt.py

@@ -40,6 +40,7 @@
 from robottelo.exceptions import CLIReturnCodeError
 from robottelo.hosts import ContentHost
 from robottelo.utils.datafactory import parametrized
+from robottelo.utils.issue_handlers import is_open
 
 LIBVIRT_URL = LIBVIRT_RESOURCE_URL % settings.libvirt.libvirt_hostname
 
@@ -371,7 +372,7 @@ def test_positive_update_console_password(libvirt_url, set_console_password, mod
 @pytest.mark.e2e
 @pytest.mark.on_premises_provisioning
 @pytest.mark.rhel_ver_match('[7]')
-@pytest.mark.parametrize('pxe_loader', ['uefi', 'secureboot'], indirect=True)
+@pytest.mark.parametrize('pxe_loader', ['bios', 'uefi', 'secureboot'], indirect=True)
 @pytest.mark.parametrize('setting_update', ['destroy_vm_on_host_delete=True'], indirect=True)
 def test_positive_provision_end_to_end(
     request,
@@ -406,6 +407,10 @@ def test_positive_provision_end_to_end(
 
     :customerscenario: true
     """
+    # Skip test for UEFI and SecureBoot loaders
+    if is_open('SAT-41340') and pxe_loader.vm_firmware in ['uefi', 'uefi_secure_boot']:
+        pytest.skip(f"Test not supported for {pxe_loader.vm_firmware} firmware")
+
     sat = module_libvirt_provisioning_sat.sat
     cr_name = gen_string('alpha')
     hostname = gen_string('alpha').lower()
@@ -450,10 +455,15 @@ def test_positive_provision_end_to_end(
     assert hostname in result.stdout
 
     wait_for(
-        lambda: sat.cli.Host.info({'name': hostname})['status']['build-status']
-        != 'Pending installation',
+        lambda: (
+            sat.cli.Host.info({'name': hostname})
+            .get('status', {})
+            .get('build-status', 'Pending installation')
+            != 'Pending installation'
+        ),
         timeout=1800,
         delay=30,
+        handle_exception=True,
     )
     host_info = sat.cli.Host.info({'id': host['id']})
     assert host_info['status']['build-status'] == 'Installed'

tests/foreman/ui/test_computeresource_libvirt.py

@@ -181,7 +181,8 @@ def test_positive_provision_end_to_end(
         )
         name = f'{hostname}.{module_libvirt_provisioning_sat.domain.name}'
         request.addfinalizer(lambda: sat.provisioning_cleanup(name))
-        assert session.host.search(name)[0]['Name'] == name
+        result = session.host_new.search(name)[0]
+        assert result['Name'] == name
 
         # Check on Libvirt, if VM exists
         result = sat.execute(