Skip to content

Commit 79e5f38

Browse files
pondrejkweb-flow
authored andcommitted
set the logout redirect setting within the test body (#20824)
(cherry picked from commit c18855a)
1 parent 385d53d commit 79e5f38

1 file changed

Lines changed: 18 additions & 12 deletions

File tree

tests/foreman/destructive/test_ldap_authentication.py

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -266,14 +266,8 @@ def test_single_sign_on_ldap_ad_server(
266266
assert f'{url}/new/hosts' in result.stdout
267267

268268

269-
@pytest.mark.parametrize(
270-
'setting_update',
271-
[f'login_delegation_logout_url={LOGIN_DELEGATION_LOGOUT_URL}'],
272-
ids=["external_redirect"],
273-
indirect=True,
274-
)
275269
def test_single_sign_on_using_rhsso(
276-
enable_external_auth_rhsso, rhsso_setting_setup, module_target_sat, setting_update
270+
enable_external_auth_rhsso, rhsso_setting_setup, module_target_sat
277271
):
278272
"""Verify the single sign-on functionality with external authentication RH-SSO
279273
@@ -299,11 +293,23 @@ def test_single_sign_on_using_rhsso(
299293
actual_user = session.task.read_all(widget_names="current_user")['current_user']
300294
assert settings.rhsso.rhsso_user in actual_user
301295
# logout verification for SAT-40322
302-
session.rhsso_login.logout()
303-
assert session.browser.url == LOGIN_DELEGATION_LOGOUT_URL, "Unsuccessful logout redirect"
304-
with pytest.raises(NavigationTriesExceeded) as error:
305-
session.task.read_all(widget_names='current_user')['current_user']
306-
assert error.typename == 'NavigationTriesExceeded'
296+
setting_object = module_target_sat.api.Setting().search(
297+
query={'search': 'name=login_delegation_logout_url'}
298+
)[0]
299+
default_setting_value = '' if setting_object.value is None else setting_object.value
300+
setting_object.value = LOGIN_DELEGATION_LOGOUT_URL
301+
setting_object.update({'value'})
302+
try:
303+
session.rhsso_login.logout()
304+
assert session.browser.url == LOGIN_DELEGATION_LOGOUT_URL, (
305+
"Unsuccessful logout redirect"
306+
)
307+
with pytest.raises(NavigationTriesExceeded) as error:
308+
session.task.read_all(widget_names='current_user')['current_user']
309+
assert error.typename == 'NavigationTriesExceeded'
310+
finally:
311+
setting_object.value = default_setting_value
312+
setting_object.update({'value'})
307313

308314

309315
def test_external_logout_rhsso(rhsso_setting_setup, enable_external_auth_rhsso, module_target_sat):

0 commit comments

Comments
 (0)