update test for enable/disable recommendations (IoP) (#20520)

* update test for enable disable iop

* Fix failing tests and fixture

* pre-commit

* update pytest marker

* add enable functionality to iop

* update pytest marker

* update test with new entity

* update to rhel 10 for recommendations

(cherry picked from commit 0b9ef3c)

Author: ColeHiggins2

tests/foreman/ui/test_rhcloud_iop.py

@@ -280,15 +280,15 @@ def test_rhcloud_inventory_disabled_local_insights(module_target_sat_insights):
 
 @pytest.mark.e2e
 @pytest.mark.no_containers
-@pytest.mark.rhel_ver_match(r'^(?![78]).*')
+@pytest.mark.rhel_ver_match('10')
 @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True)
 def test_iop_recommendations_remediation_type_and_status(
     rhel_insights_vm,
     rhcloud_manifest_org,
     module_target_sat_insights,
 ):
     """Set up Satellite with iop enabled, verify recommendations remediation type,
-    and test filtering recommendations by status.
+    disable the recommendation, check status, then re-enable the recommendation.
 
     :id: 62834698-b4b8-4218-855c-2b2aa584b364
 
@@ -297,21 +297,18 @@ def test_iop_recommendations_remediation_type_and_status(
         2. In Satellite UI, go to Red Hat Lightspeed > Recommendations.
         3. Search for "OpenSSH config permissions" recommendation.
         4. Verify the recommendation's remediation type is "Playbook".
-        5. Apply filter for "Enabled" status recommendations.
-        6. Verify Enabled recommendations are greater than 0.
-        7. Apply filter for "Disabled" status recommendations.
-        8. Verify Disabled recommendations are 0.
+        5. Disable recommendation.
+        6. Verify recommendation is disabled.
+        7. Re-enable recommendation.
+        8. Verify recommendation is enabled.
 
     :expectedresults:
         1. Red Hat Lightspeed recommendation related to "OpenSSH config permissions" issue is listed
             for misconfigured machine.
         2. The recommendation has remediation type "Playbook".
-        3. Enabled recommendations are displayed (count greater than 0).
-        4. No disabled recommendations are displayed.
+        3. Recommendation can be disabled and re-enabled.
 
-    :CaseImportance: Critical
-
-    :Verifies: SAT-32566
+    :Verifies: SAT-32566, SAT-38139
 
     :parametrized: yes
 
@@ -338,10 +335,20 @@ def test_iop_recommendations_remediation_type_and_status(
         assert result[0]['Name'] == OPENSSH_RECOMMENDATION
         assert result[0]['Remediation type'] == 'Playbook'
 
-        # Verify that enabled recommendations are greater than 0
-        result = session.recommendationstab.apply_filter("Status", "Enabled")
-        assert len(result) > 0
-
-        # Verify that Disabled recommnedations are 0
+        # Disable recommendation
+        session.recommendationstab.disable_recommendation(
+            recommendation_name=OPENSSH_RECOMMENDATION
+        )
+        # Verify that the disabled recommendation is filtered
         result = session.recommendationstab.apply_filter("Status", "Disabled")
-        assert 'No recommendations' in result[0]['Name']
+        assert 'Decreased security: OpenSSH config permissions' in result[0]['Name']
+
+        session.recommendationstab.enable_recommendation(
+            recommendation_name='Decreased security: OpenSSH config permissions'
+        )
+        # Verify that recommendation is enabled
+        session.recommendationstab.apply_filter("Status", "Enabled")
+        result = session.recommendationstab.apply_filter(
+            "Name", OPENSSH_RECOMMENDATION, is_search=True
+        )
+        assert 'Decreased security: OpenSSH config permissions' in result[0]['Name']