Modifications in Libvirt CR to resolve key error

Author: nacoool

pytest_fixtures/component/provision_libvirt.py

@@ -39,6 +39,8 @@ def module_libvirt_image(module_target_sat, module_cr_libvirt):
 def module_libvirt_provisioning_sat(module_provisioning_sat, libvirt):
     # Configure Libvirt CR for provisioning
     module_provisioning_sat.sat.configure_libvirt_cr(server_fqdn=libvirt.fqdn)
+    # Restart DHCP service for libvirt provisioning
+    module_provisioning_sat.sat.execute('systemctl restart dhcpd')
     return module_provisioning_sat
 
 

tests/foreman/cli/test_computeresource_libvirt.py

@@ -40,6 +40,7 @@
 from robottelo.exceptions import CLIReturnCodeError
 from robottelo.hosts import ContentHost
 from robottelo.utils.datafactory import parametrized
+from robottelo.utils.issue_handlers import is_open
 
 
 def valid_name_desc_data():
@@ -363,7 +364,7 @@ def test_positive_update_console_password(set_console_password, module_target_sa
 @pytest.mark.e2e
 @pytest.mark.on_premises_provisioning
 @pytest.mark.rhel_ver_match('[7]')
-@pytest.mark.parametrize('pxe_loader', ['uefi', 'secureboot'], indirect=True)
+@pytest.mark.parametrize('pxe_loader', ['bios', 'uefi', 'secureboot'], indirect=True)
 @pytest.mark.parametrize('setting_update', ['destroy_vm_on_host_delete=True'], indirect=True)
 @pytest.mark.parametrize('libvirt', ['libvirt9', 'libvirt10'], indirect=True)
 def test_positive_provision_end_to_end(
@@ -376,6 +377,7 @@ def test_positive_provision_end_to_end(
     module_location,
     provisioning_hostgroup,
     module_provisioning_rhel_content,
+    module_restart_dhcpd,
 ):
     """Provision a host on Libvirt compute resource with the help of hostgroup.
 
@@ -400,6 +402,10 @@ def test_positive_provision_end_to_end(
 
     :customerscenario: true
     """
+    # Skip test for UEFI and SecureBoot loaders
+    if is_open('SAT-41340') and pxe_loader.vm_firmware in ['uefi', 'uefi_secure_boot']:
+        pytest.skip(f"Test not supported for {pxe_loader.vm_firmware} firmware")
+
     sat = module_libvirt_provisioning_sat.sat
     cr_name = gen_string('alpha')
     hostname = gen_string('alpha').lower()
@@ -442,12 +448,16 @@ def test_positive_provision_end_to_end(
         f'su foreman -s /bin/bash -c "virsh -c {libvirt.url} list --state-running"'
     )
     assert hostname in result.stdout
-
     wait_for(
-        lambda: sat.cli.Host.info({'name': hostname})['status']['build-status']
-        != 'Pending installation',
+        lambda: (
+            sat.cli.Host.info({'name': hostname})
+            .get('status', {})
+            .get('build-status', 'Pending installation')
+            != 'Pending installation'
+        ),
         timeout=1800,
         delay=30,
+        handle_exception=True,
     )
     host_info = sat.cli.Host.info({'id': host['id']})
     assert host_info['status']['build-status'] == 'Installed'

tests/foreman/ui/test_computeresource_libvirt.py

@@ -131,6 +131,7 @@ def test_positive_provision_end_to_end(
     provisioning_hostgroup,
     module_libvirt_provisioning_sat,
     module_provisioning_rhel_content,
+    module_restart_dhcpd,
 ):
     """Provision Host on libvirt compute resource, and delete it afterwards
 
@@ -181,8 +182,8 @@ def test_positive_provision_end_to_end(
         )
         name = f'{hostname}.{module_libvirt_provisioning_sat.domain.name}'
         request.addfinalizer(lambda: sat.provisioning_cleanup(name))
-        assert session.host_new.search(name)[0]['Name'] == name
-
+        result = session.host_new.search(name)[0]
+        assert result['Name'] == name
         # Check on Libvirt, if VM exists
         result = sat.execute(
             f'su foreman -s /bin/bash -c "virsh -c {libvirt.url} list --state-running"'