From 2b83c12c6b3133a214aaa9620933e98ec79b2ab9 Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Tue, 16 Dec 2025 17:51:21 -0500 Subject: [PATCH 1/8] update test for enable disable iop --- tests/foreman/ui/test_rhcloud_iop.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index dfaa7ebce04..3bbf9c39f7a 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -342,6 +342,10 @@ def test_iop_recommendations_remediation_type_and_status( result = session.recommendationstab.apply_filter("Status", "Enabled") assert len(result) > 0 - # Verify that Disabled recommnedations are 0 + # Disable recommendation + session.recommendationstab.disable_recommendation_for_system( + recommendation_name=OPENSSH_RECOMMENDATION, hostname=rhel_insights_vm.hostname + ) + # Verify that the disabled recommendation is filtered result = session.recommendationstab.apply_filter("Status", "Disabled") - assert 'No recommendations' in result[0]['Name'] + assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] From 2833d69b62371aa3bdb00d8e5cad581cdfef10ff Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Fri, 19 Dec 2025 10:45:44 -0500 Subject: [PATCH 2/8] Fix failing tests and fixture --- tests/foreman/ui/test_rhcloud_iop.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 3bbf9c39f7a..62e8a9f2e49 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -281,7 +281,7 @@ def test_rhcloud_inventory_disabled_local_insights(module_target_sat_insights): @pytest.mark.e2e @pytest.mark.no_containers @pytest.mark.rhel_ver_match(r'^(?![78]).*') -@pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True) +@pytest.mark.parametrize('module_target_sat_insights', [True], ids=['local'], indirect=True) def test_iop_recommendations_remediation_type_and_status( rhel_insights_vm, rhcloud_manifest_org, @@ -338,14 +338,9 @@ def test_iop_recommendations_remediation_type_and_status( assert result[0]['Name'] == OPENSSH_RECOMMENDATION assert result[0]['Remediation type'] == 'Playbook' - # Verify that enabled recommendations are greater than 0 - result = session.recommendationstab.apply_filter("Status", "Enabled") - assert len(result) > 0 - # Disable recommendation - session.recommendationstab.disable_recommendation_for_system( - recommendation_name=OPENSSH_RECOMMENDATION, hostname=rhel_insights_vm.hostname - ) + session.recommendationstab.disable_recommendation( + recommendation_name=OPENSSH_RECOMMENDATION) # Verify that the disabled recommendation is filtered result = session.recommendationstab.apply_filter("Status", "Disabled") assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] From 9e9bbc56a9ab1827288bb21ff63a8ff9f0ce5d6f Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Fri, 19 Dec 2025 11:39:34 -0500 Subject: [PATCH 3/8] pre-commit --- tests/foreman/ui/test_rhcloud_iop.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 62e8a9f2e49..01298a17c69 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -340,7 +340,8 @@ def test_iop_recommendations_remediation_type_and_status( # Disable recommendation session.recommendationstab.disable_recommendation( - recommendation_name=OPENSSH_RECOMMENDATION) + recommendation_name=OPENSSH_RECOMMENDATION + ) # Verify that the disabled recommendation is filtered result = session.recommendationstab.apply_filter("Status", "Disabled") assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] From fa6a1c463e73ed0cb78f95ea1c164e4469dc46e0 Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Fri, 19 Dec 2025 11:40:45 -0500 Subject: [PATCH 4/8] update pytest marker --- tests/foreman/ui/test_rhcloud_iop.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 01298a17c69..e7969093bc3 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -281,7 +281,7 @@ def test_rhcloud_inventory_disabled_local_insights(module_target_sat_insights): @pytest.mark.e2e @pytest.mark.no_containers @pytest.mark.rhel_ver_match(r'^(?![78]).*') -@pytest.mark.parametrize('module_target_sat_insights', [True], ids=['local'], indirect=True) +@pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True) def test_iop_recommendations_remediation_type_and_status( rhel_insights_vm, rhcloud_manifest_org, From 2885354cc30de4ea82788c2377ae8ddfd36e2c4d Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Fri, 19 Dec 2025 18:02:55 -0500 Subject: [PATCH 5/8] add enable functionality to iop --- tests/foreman/ui/test_rhcloud_iop.py | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index e7969093bc3..366b469ba0b 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -288,7 +288,7 @@ def test_iop_recommendations_remediation_type_and_status( module_target_sat_insights, ): """Set up Satellite with iop enabled, verify recommendations remediation type, - and test filtering recommendations by status. + disable the recommendation, check status, then re-enable the recommendation. :id: 62834698-b4b8-4218-855c-2b2aa584b364 @@ -297,21 +297,18 @@ def test_iop_recommendations_remediation_type_and_status( 2. In Satellite UI, go to Red Hat Lightspeed > Recommendations. 3. Search for "OpenSSH config permissions" recommendation. 4. Verify the recommendation's remediation type is "Playbook". - 5. Apply filter for "Enabled" status recommendations. - 6. Verify Enabled recommendations are greater than 0. - 7. Apply filter for "Disabled" status recommendations. - 8. Verify Disabled recommendations are 0. + 5. Disable recommendation. + 6. Verify recommendation is disabled. + 7. Re-enable recommendation. + 8. Verify recommendation is enabled. :expectedresults: 1. Red Hat Lightspeed recommendation related to "OpenSSH config permissions" issue is listed for misconfigured machine. 2. The recommendation has remediation type "Playbook". - 3. Enabled recommendations are displayed (count greater than 0). - 4. No disabled recommendations are displayed. + 3. Recommendation can be disabled and re-enabled. - :CaseImportance: Critical - - :Verifies: SAT-32566 + :Verifies: SAT-32566, SAT-38139 :parametrized: yes @@ -345,3 +342,10 @@ def test_iop_recommendations_remediation_type_and_status( # Verify that the disabled recommendation is filtered result = session.recommendationstab.apply_filter("Status", "Disabled") assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] + + session.recommendationstab.enable_recommendation( + recommendation_name='Decreased security: OpenSSH config permissions' + ) + + result = session.recommendationstab.apply_filter("Status", "Enabled") + assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] From e776112519a3949f285092fe86d74e2571b023c5 Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Thu, 12 Feb 2026 14:11:05 -0500 Subject: [PATCH 6/8] update pytest marker --- tests/foreman/ui/test_rhcloud_iop.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 366b469ba0b..7cd066a7fd9 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -280,7 +280,7 @@ def test_rhcloud_inventory_disabled_local_insights(module_target_sat_insights): @pytest.mark.e2e @pytest.mark.no_containers -@pytest.mark.rhel_ver_match(r'^(?![78]).*') +@pytest.mark.rhel_ver_match('N-1') @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True) def test_iop_recommendations_remediation_type_and_status( rhel_insights_vm, From 901ec9fc009254ab1e3cd98331e5a0633ae3d8b9 Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Thu, 19 Feb 2026 15:13:24 -0500 Subject: [PATCH 7/8] update test with new entity --- tests/foreman/ui/test_rhcloud_iop.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 7cd066a7fd9..74efa132f2d 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -346,6 +346,9 @@ def test_iop_recommendations_remediation_type_and_status( session.recommendationstab.enable_recommendation( recommendation_name='Decreased security: OpenSSH config permissions' ) - - result = session.recommendationstab.apply_filter("Status", "Enabled") + # Verify that recommendation is enabled + session.recommendationstab.apply_filter("Status", "Enabled") + result = session.recommendationstab.apply_filter( + "Name", OPENSSH_RECOMMENDATION, is_search=True + ) assert 'Decreased security: OpenSSH config permissions' in result[0]['Name'] From 124ab14eae39f5bd4893c2144cbccb77142b4bdb Mon Sep 17 00:00:00 2001 From: Cole Higgins Date: Wed, 25 Feb 2026 14:59:43 -0500 Subject: [PATCH 8/8] update to rhel 10 for recommendations --- tests/foreman/ui/test_rhcloud_iop.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/foreman/ui/test_rhcloud_iop.py b/tests/foreman/ui/test_rhcloud_iop.py index 74efa132f2d..2bd1868a4a9 100644 --- a/tests/foreman/ui/test_rhcloud_iop.py +++ b/tests/foreman/ui/test_rhcloud_iop.py @@ -280,7 +280,7 @@ def test_rhcloud_inventory_disabled_local_insights(module_target_sat_insights): @pytest.mark.e2e @pytest.mark.no_containers -@pytest.mark.rhel_ver_match('N-1') +@pytest.mark.rhel_ver_match('10') @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True) def test_iop_recommendations_remediation_type_and_status( rhel_insights_vm,