[6.19.z] Add test for Katello 11637 - #20862
Merged
Satellite-QE merged 1 commit intoFeb 26, 2026
Merged
Conversation
Collaborator
Author
|
Contributor
Reviewer's GuideAdds a new end-to-end UI test to verify that a host can be reassigned to a different content view within the same lifecycle environment, covering the Katello 11637 bugfix scenario. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The activation key is created against
module_org.library.idwhile the second content view is promoted tomodule_lce, which doesn’t match the test docstring steps describing a new lifecycle environment; consider aligning the AK environment and registration path withmodule_lceto more accurately exercise the multicv-in-same-LCE scenario. - When asserting the assigned content view via
get_content_view_envs(...)[0], the test assumes the first returned environment is the one under test; filtering by the specific lifecycle environment instead of indexing would make the assertion more robust if multiple environments are present.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The activation key is created against `module_org.library.id` while the second content view is promoted to `module_lce`, which doesn’t match the test docstring steps describing a new lifecycle environment; consider aligning the AK environment and registration path with `module_lce` to more accurately exercise the multicv-in-same-LCE scenario.
- When asserting the assigned content view via `get_content_view_envs(...)[0]`, the test assumes the first returned environment is the one under test; filtering by the specific lifecycle environment instead of indexing would make the assertion more robust if multiple environments are present.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
trigger: test-robottelo |
Collaborator
Author
|
PRT Result |
Contributor
|
Collaborator
Author
|
PRT Result |
Contributor
|
This PR is passing when I check it out and run it locally. I'll try debugging in the CI environment tomorrow. |
synkd
force-pushed
the
cherry-pick-6.19.z-b63db29008c99e58249bccc22cd2b912c3d356a5
branch
from
February 26, 2026 15:00
f6d5e53 to
f8a15e2
Compare
Contributor
|
2 similar comments
Contributor
|
Contributor
|
Collaborator
Author
|
PRT Result |
synkd
force-pushed
the
cherry-pick-6.19.z-b63db29008c99e58249bccc22cd2b912c3d356a5
branch
from
February 26, 2026 19:11
dc1fc11 to
702513f
Compare
This PR adds test coverage for Katello/katello#11637, which a bug found in the initial multicv host implementation in which changing the content view in a host's content view environment to a different content view in the same lifecycle environment did not function properly. Requires SatelliteQE/airgun#2321. (cherry picked from commit b63db29)
synkd
force-pushed
the
cherry-pick-6.19.z-b63db29008c99e58249bccc22cd2b912c3d356a5
branch
from
February 26, 2026 19:16
702513f to
e5d5ce6
Compare
Contributor
|
PRT run 14518 passed when I stepped through the test with |
Contributor
|
Collaborator
Author
|
PRT Result |
Satellite-QE
deleted the
cherry-pick-6.19.z-b63db29008c99e58249bccc22cd2b912c3d356a5
branch
February 26, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #20860
This PR adds test coverage for Katello/katello#11637, which a bug found in the initial multicv host implementation in which changing the content view in a host's content view environment to a different content view in the same lifecycle environment did not function properly.
Requires SatelliteQE/airgun#2321.
Summary by Sourcery
Tests: