Skip to content

Update Download Report CLI test - #20865

Merged
synkd merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:updateDownloadReportCliTest
Feb 25, 2026
Merged

Update Download Report CLI test#20865
synkd merged 1 commit into
SatelliteQE:masterfrom
LadislavVasina1:updateDownloadReportCliTest

Conversation

@LadislavVasina1

@LadislavVasina1 LadislavVasina1 commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue which was blocking this test is resolved in upstream.

PRT test Cases example

image 
trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k "test_positive_download_reports_job_cli_disconnected"
theforeman:
    foreman_rh_cloud: 1155

Summary by Sourcery

Tests:

  • Restrict the disconnected download reports CLI test to RHEL N-2 and update its metadata to verify SAT-41462 instead of marking it blocked.

@LadislavVasina1 LadislavVasina1 self-assigned this Feb 25, 2026
@LadislavVasina1
LadislavVasina1 requested a review from a team as a code owner February 25, 2026 11:46
@LadislavVasina1 LadislavVasina1 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 25, 2026
@sourcery-ai

sourcery-ai Bot commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR re-enables and scopes the disconnected download reports CLI test by marking it for RHEL N-2 environments and updating its metadata from a blocked bug reference to a verification of the resolved issue.

File-Level Changes

Change Details Files
Scope the disconnected download reports CLI test to RHEL N-2 environments and update its metadata to indicate it verifies the previously blocking issue.
  • Add a pytest marker to restrict the test to RHEL N-2 versions
  • Change the test case docstring from indicating it is blocked by SAT-41462 to indicating it now verifies SAT-41462
 tests/foreman/cli/test_rhcloud_inventory.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot reviewed Feb 25, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether @pytest.mark.rhel_ver_match('N-2') should also apply to the related test_positive_generate_reports_job_cli_disconnected test for consistency, or alternatively document in-code why only the download test is version-gated.
  • If SAT-41462 is now fully verified by this test, you might want to check whether any additional acceptance criteria from that issue require separate tests, to keep this one focused on the download CLI behavior only.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Consider whether `@pytest.mark.rhel_ver_match('N-2')` should also apply to the related `test_positive_generate_reports_job_cli_disconnected` test for consistency, or alternatively document in-code why only the download test is version-gated.
- If SAT-41462 is now fully verified by this test, you might want to check whether any additional acceptance criteria from that issue require separate tests, to keep this one focused on the download CLI behavior only.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LadislavVasina1

LadislavVasina1 commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author 
trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k "test_positive_download_reports_job_cli_disconnected"
theforeman:
    foreman_rh_cloud: 1155
env:
    ROBOTTELO_server__version__snap: '166.0'

@synkd
synkd merged commit b8e3549 into SatelliteQE:master Feb 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments
@jeremylenz jeremylenz jeremylenz approved these changes
@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes
@synkd synkd synkd approved these changes
@jnagare-redhat jnagare-redhat Awaiting requested review from jnagare-redhat

Assignees

@LadislavVasina1 LadislavVasina1

Labels

No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LadislavVasina1 @jeremylenz @ColeHiggins2 @synkd