Reviewer's Guide

Adjusts the future-dated subscription manifest fixture to only create/yield the manifest and moves the manifest upload into the specific UI test, making the test responsible for uploading the manifest it depends on.

Sequence diagram for future-dated subscription manifest handling in UI test

sequenceDiagram
    participant Pytest
    participant Test as test_positive_populate_future_date_subcription
    participant Fixture as func_future_dated_subscription_manifest
    participant Manifester
    participant Org as function_org
    participant Sat as target_sat

    Pytest->>Test: Execute test
    Test->>Fixture: Request future_dated_subscription_manifest
    activate Fixture
    Fixture->>Manifester: __enter__(manifest_category=future_date_subscription)
    activate Manifester
    Manifester-->>Fixture: manifest (content)
    deactivate Manifester
    Fixture-->>Test: yield manifest
    deactivate Fixture

    Test->>Sat: upload_manifest(org_id=Org.id, content=manifest.content)
    Sat-->>Test: upload result

    Test->>Test: Perform UI steps validating future-dated subscription
    Test-->>Pytest: Test result

    activate Manifester
    Test->>Manifester: __exit__()
    deactivate Manifester

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.