Thanks for the reply @moltar

I just looked at your Add Node 18 to tests commit and see that this is testing node-fetch under Node 18. Always good to have this coverage. Thanks for adding this.

What I'm talking about here is that fetch is now available on global from Node 18 onward. If you use nvm to manage your Node versions then this should demonstrate:

$ nvm use 18
Now using node v18.12.1 (npm v8.19.2)

$ node
Welcome to Node.js v18.12.1.
Type ".help" for more information.
> fetch
[AsyncFunction: fetch]

$ nvm use 16
Now using node v16.18.1 (npm v8.19.2)

$ node
Welcome to Node.js v16.18.1.
Type ".help" for more information.
> fetch
Uncaught ReferenceError: fetch is not defined

PollyJS have a Fetch Adapter that has the byline:

The fetch adapter wraps the global fetch method for seamless recording and replaying of requests.

And this is different to their HTTP Adapter which is what this module is using.

I'm wondering if there need to be 2 distinct jest-polly modules? One that handles each of these adapters. Or could they co-exist? If they co-existed then one would also have to ensure that Node >= 18 etc.

Is jest-polly compatible with Node 18.3+ fetch #342

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions