fix: enable strict validation for Jovo language model - #6279
Merged
hyperupcall merged 1 commit intoAug 31, 2026
Conversation
Signed-off-by: Solaris-star <820622658@qq.com>
Solaris-star
requested review from
hyperupcall and
madskristensen
as code owners
August 31, 2026 16:15
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #6038.
This replaces the non-strict union type in
jovo-language-model.jsonwith equivalentoneOfbranches, then removes the schema fromajvNotStrictMode.Validation completed locally:
npm run prettier -- --check src/schemas/json/jovo-language-model.json src/schema-validation.jsoncnpm run typechecknpm run eslintnode ./cli.js checknode ./cli.js coveragegit diff --check