Skip to content

Commit 1c34bea

Browse files
committed
Update Setup
1 parent 146b1f1 commit 1c34bea

10 files changed

Lines changed: 34 additions & 34 deletions

File tree

.github/workflows/build-and-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ concurrency:
2020
jobs:
2121
mhc_app_unit_tests:
2222
name: App Unit Tests
23-
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@testPR
23+
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@v0.2
2424
permissions:
2525
contents: read
2626
with:
@@ -31,7 +31,7 @@ jobs:
3131
artifactname: MHC-App-UnitTests.xcresult
3232
mhc_app_ui_tests:
3333
name: App UI Tests
34-
uses: SchmiedmayerLab/.github/.github/workflows/firebase-emulators-exec.yml@testPR
34+
uses: SchmiedmayerLab/.github/.github/workflows/firebase-emulators-exec.yml@v0.2
3535
permissions:
3636
contents: read
3737
with:
@@ -43,7 +43,7 @@ jobs:
4343
GOOGLE_APPLICATION_CREDENTIALS_BASE64: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_BASE64 }}
4444
mhc_utils_unit_tests:
4545
name: Utils Unit Tests (${{ matrix.platform.name }} ${{ matrix.config }})
46-
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@testPR
46+
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@v0.2
4747
permissions:
4848
contents: read
4949
strategy:
@@ -63,7 +63,7 @@ jobs:
6363
artifactname: ${{ format('MHC-Shared-UnitTests-{0}-{1}.xcresult', matrix.platform.name, matrix.config) }}
6464
mhc_utils_unit_tests_linux:
6565
name: Utils Unit Tests (Linux ${{ matrix.config }})
66-
uses: SchmiedmayerLab/.github/.github/workflows/swift-test.yml@testPR
66+
uses: SchmiedmayerLab/.github/.github/workflows/swift-test.yml@v0.2
6767
permissions:
6868
contents: read
6969
strategy:
@@ -76,7 +76,7 @@ jobs:
7676
uploadcoveragereport:
7777
name: Upload Coverage Report
7878
needs: [mhc_app_unit_tests, mhc_app_ui_tests, mhc_utils_unit_tests, mhc_utils_unit_tests_linux]
79-
uses: SchmiedmayerLab/.github/.github/workflows/coverage.yml@testPR
79+
uses: SchmiedmayerLab/.github/.github/workflows/coverage.yml@v0.2
8080
permissions:
8181
actions: read
8282
contents: read

.github/workflows/deployment.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
environment: ${{ steps.determineenvironment.outputs.environment }}
7878
steps:
7979
- name: Checkout code
80-
uses: actions/checkout@v4
80+
uses: actions/checkout@v6
8181
- name: Determine Environment
8282
id: determineenvironment
8383
run: |
@@ -96,7 +96,7 @@ jobs:
9696
version: ${{ steps.script.outputs.version }}
9797
steps:
9898
- name: Checkout code
99-
uses: actions/checkout@v4
99+
uses: actions/checkout@v6
100100
- uses: actions-ecosystem/action-get-latest-tag@v1
101101
id: get-latest-tag
102102
with:
@@ -119,17 +119,17 @@ jobs:
119119
fi
120120
echo "buildnumber: ${{ inputs.buildnumber }}"
121121
echo "releasenotes: ${{ inputs.releasenotes }}"
122-
# test:
123-
# name: Build and Test
124-
# needs: determineenvironment
125-
# uses: ./.github/workflows/build-and-test.yml
126-
# permissions:
127-
# contents: read
128-
# secrets: inherit
122+
test:
123+
name: Build and Test
124+
needs: determineenvironment
125+
uses: ./.github/workflows/build-and-test.yml
126+
permissions:
127+
contents: read
128+
secrets: inherit
129129
testflight:
130130
name: iOS App TestFlight Deployment
131-
needs: [determineenvironment, vars] #, test]
132-
uses: SchmiedmayerLab/.github/.github/workflows/xcode-deploy.yml@testPR
131+
needs: [determineenvironment, vars, test]
132+
uses: SchmiedmayerLab/.github/.github/workflows/xcode-deploy.yml@v0.2
133133
permissions:
134134
contents: read
135135
with:

.github/workflows/monthly-markdown-link-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ on:
1616
jobs:
1717
markdown_link_check:
1818
name: Markdown Link Check
19-
uses: SchmiedmayerLab/.github/.github/workflows/markdown-links.yml@testPR
19+
uses: SchmiedmayerLab/.github/.github/workflows/markdown-links.yml@v0.2
2020
permissions:
2121
contents: read

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ concurrency:
1919
jobs:
2020
formatreleasenotes:
2121
name: Format Release Notes
22-
uses: SchmiedmayerLab/.github/.github/workflows/format-release-notes.yml@testPR
22+
uses: SchmiedmayerLab/.github/.github/workflows/format-release-notes.yml@v0.2
2323
permissions:
2424
contents: read
2525
with:

.github/workflows/static-analysis.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,30 +20,30 @@ concurrency:
2020
jobs:
2121
reuse_action:
2222
name: REUSE Compliance Check
23-
uses: SchmiedmayerLab/.github/.github/workflows/reuse.yml@testPR
23+
uses: SchmiedmayerLab/.github/.github/workflows/reuse.yml@v0.2
2424
permissions:
2525
contents: read
2626
swiftlint:
2727
name: SwiftLint
28-
uses: SchmiedmayerLab/.github/.github/workflows/swiftlint.yml@testPR
28+
uses: SchmiedmayerLab/.github/.github/workflows/swiftlint.yml@v0.2
2929
permissions:
3030
contents: read
3131
periphery:
3232
name: Periphery
33-
uses: SchmiedmayerLab/.github/.github/workflows/periphery.yml@testPR
33+
uses: SchmiedmayerLab/.github/.github/workflows/periphery.yml@v0.2
3434
permissions:
3535
contents: read
3636
with:
3737
runsonlabels: '["macOS", "self-hosted"]'
3838
strict: false
3939
markdownlinkcheck:
4040
name: Markdown Link Check
41-
uses: SchmiedmayerLab/.github/.github/workflows/markdown-links.yml@testPR
41+
uses: SchmiedmayerLab/.github/.github/workflows/markdown-links.yml@v0.2
4242
permissions:
4343
contents: read
4444
codeql:
4545
name: CodeQL
46-
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@testPR
46+
uses: SchmiedmayerLab/.github/.github/workflows/xcodebuild.yml@v0.2
4747
permissions:
4848
security-events: write
4949
actions: read

MyHeartCounts.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,8 +1035,8 @@
10351035
OTHER_SWIFT_FLAGS = "$(inherited)";
10361036
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.MyHeartCounts;
10371037
PRODUCT_NAME = "$(TARGET_NAME)";
1038-
PROVISIONING_PROFILE_SPECIFIER = "My Heart Counts - Biodesign Digital Health";
1039-
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "My Heart Counts - Biodesign Digital Health";
1038+
PROVISIONING_PROFILE_SPECIFIER = "My Heart Counts";
1039+
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "My Heart Counts";
10401040
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
10411041
SUPPORTS_MACCATALYST = NO;
10421042
SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD = NO;
@@ -1179,8 +1179,8 @@
11791179
MARKETING_VERSION = 1.0;
11801180
PRODUCT_BUNDLE_IDENTIFIER = edu.stanford.MyHeartCounts.watchkitapp;
11811181
PRODUCT_NAME = "$(TARGET_NAME)";
1182-
PROVISIONING_PROFILE_SPECIFIER = "My Heart Counts - Biodesign Digital Health - Watch";
1183-
"PROVISIONING_PROFILE_SPECIFIER[sdk=watchos*]" = "My Heart Counts - Biodesign Digital Health - Watch";
1182+
PROVISIONING_PROFILE_SPECIFIER = "My Heart Counts - Watch";
1183+
"PROVISIONING_PROFILE_SPECIFIER[sdk=watchos*]" = "My Heart Counts - Watch";
11841184
SDKROOT = watchos;
11851185
SKIP_INSTALL = YES;
11861186
SWIFT_EMIT_LOC_STRINGS = YES;

MyHeartCounts/Home Tab/Prompted Actions/PromptedAction.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ extension HomeTab {
7373
lastResult = await Result {
7474
try await handler(spezi)
7575
}
76-
return try lastResult!.get() // swiftlint:disable:this force_unwrapping return_value_from_void_function
76+
try lastResult!.get() // swiftlint:disable:this force_unwrapping
7777
}
7878
}
7979
}

MyHeartCounts/Modules/StudyBundleLoader.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,14 @@ final class StudyBundleLoader: Module, Sendable {
8888
case (.none, _), (.some(.failure), _):
8989
value = newValue
9090
return .changed(newValue)
91-
case (.some(.success(let oldBundle)), .success(let newBundle)):
91+
case let (.some(.success(oldBundle)), .success(newBundle)):
9292
if newBundle != oldBundle {
9393
value = .success(newBundle)
9494
return .changed(.success(newBundle))
9595
} else {
9696
return .unchanged(.success(oldBundle))
9797
}
98-
case (.some(.success(let oldBundle)), .failure):
98+
case let (.some(.success(oldBundle)), .failure):
9999
if preferCachedBundleOnError {
100100
// in this case (we successfully obtained a study bundle before, but it now has failed),
101101
// we keep the old bundle around instead of updating `_studyBundle` with the error case.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,5 +126,5 @@ Contributions to this project are welcome. Please make sure to read the [contrib
126126

127127
This project is licensed under the MIT License. See [Licenses](https://github.com/SchmiedmayerLab/MyHeartCounts-iOS/tree/main/LICENSES) for more information.
128128

129-
![Stanford Biodesign Footer](https://raw.githubusercontent.com/SchmiedmayerLab/.github/main/assets/biodesign-footer-light.png#gh-light-mode-only)
130-
![Stanford Biodesign Footer](https://raw.githubusercontent.com/SchmiedmayerLab/.github/main/assets/biodesign-footer-dark.png#gh-dark-mode-only)
129+
![Stanford and Stanford Medicine logos](https://raw.githubusercontent.com/SchmiedmayerLab/.github/main/assets/stanford-footer-light.png#gh-light-mode-only)
130+
![Stanford and Stanford Medicine logos](https://raw.githubusercontent.com/SchmiedmayerLab/.github/main/assets/stanford-footer-dark.png#gh-dark-mode-only)

fastlane/Fastfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ APP_CONFIG = {
1212
default_environment: "staging",
1313
default_app_identifier: "edu.stanford.MyHeartCounts",
1414
default_secondary_app_identifier: "edu.stanford.MyHeartCounts.watchkitapp",
15-
default_provisioningProfile: "My Heart Counts - Biodesign Digital Health",
16-
default_secondary_provisioningProfile: "My Heart Counts - Biodesign Digital Health - Watch",
15+
default_provisioningProfile: "My Heart Counts",
16+
default_secondary_provisioningProfile: "My Heart Counts - Watch",
1717
default_version_name: "4.0.0",
1818
default_release_notes: "Bug fixes and performance improvements.",
1919
scheme: "MyHeartCounts",

0 commit comments

Comments
 (0)