Skip to content

Commit b0abc82

Browse files
committed
chore: PR·코드리뷰·답글 한국어 작성 규칙 추가 및 PR 템플릿 준수 적용
1 parent 942201a commit b0abc82

File tree

3 files changed

+72
-45
lines changed

3 files changed

+72
-45
lines changed

.claude/commands/code-review.md

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
Review the current branch changes against develop: $ARGUMENTS
22

3+
## Rules
4+
5+
- **All review output must be written in Korean**
6+
37
## Instructions
48

59
1. Run `git diff develop...HEAD` to get the full diff
@@ -9,37 +13,38 @@ Review the current branch changes against develop: $ARGUMENTS
913

1014
## Review Criteria
1115

12-
### Must Check
13-
- **Bug risk**: null/undefined handling, async error handling, edge cases
14-
- **Security**: XSS, open redirect, sensitive data exposure, missing auth checks
15-
- **Type safety**: `any` usage, unsafe type assertions
16+
### 필수 확인
17+
- **버그 가능성**: null/undefined 처리, 비동기 에러 처리, 엣지 케이스
18+
- **보안**: XSS, 오픈 리다이렉트, 민감 정보 노출, 인증/인가 누락
19+
- **타입 안전성**: `any` 사용, 잘못된 타입 단언
1620

17-
### Code Quality
18-
- **FSD compliance**: layer dependency direction must be `app``views``widgets``entities``shared`; reverse imports are forbidden
19-
- **Unnecessary complexity**: over-abstraction, dead code
20-
- **Duplication**: repeated logic that should be extracted
21+
### 코드 품질
22+
- **FSD 규칙 준수**: 레이어 의존성 방향 `app``views``widgets``entities``shared`, 역방향 참조 금지
23+
- **불필요한 복잡도**: 과도한 추상화, 사용되지 않는 코드
24+
- **중복**: 반복되는 로직
2125

22-
### Tests
23-
- New logic should have corresponding tests
24-
- Tests should verify behavior, not implementation details
26+
### 테스트
27+
- 새 로직에 테스트가 있는지
28+
- 테스트가 구현 세부사항이 아닌 동작을 검증하는지
2529

2630
## Output Format
2731

2832
```
29-
## Code Review
33+
## 코드 리뷰
3034
31-
### Must Fix
32-
- [file:line] issue and suggestion
35+
### 🚨 필수 수정
36+
- [파일명:라인] 문제점 및 제안
3337
34-
### Recommended
35-
- [file:line] issue and suggestion
38+
### 💡 권장 개선
39+
- [파일명:라인] 문제점 및 제안
3640
37-
### Optional
38-
- [file:line] comment or opinion
41+
### 🔍 확인 사항 (선택)
42+
- [파일명:라인] 의견
3943
40-
### Good Parts
44+
### ✅ 잘된 점
4145
- ...
4246
```
4347

44-
- If no issues found, explicitly state "No issues"
45-
- Always include file path and line number for each item
48+
- 이슈가 없으면 해당 섹션 생략
49+
- 문제가 전혀 없으면 "이슈 없음" 명시
50+
- 각 항목에 파일 경로와 라인 번호 포함

.claude/commands/pr.md

Lines changed: 31 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Draft and create a pull request based on the current branch: $ARGUMENTS
22

3-
## PR Rules
3+
## Rules
44

5-
- **Base branch**: `develop` (direct PR to `main` is forbidden)
6-
- **Title**: `[type] Brief description` format, under 70 chars
7-
- **Body**: Summary + Test plan sections are required
5+
- **All PR content must be written in Korean** (title, summary, work details, review notes)
6+
- **Base branch**: always `develop` (direct PR to `main` is forbidden)
7+
- **Must follow the project PR template** defined in `.github/PULL_REQUEST_TEMPLATE.md`
88
- Merge only after CI passes
99

1010
## Instructions
@@ -13,27 +13,42 @@ Draft and create a pull request based on the current branch: $ARGUMENTS
1313

1414
1. Run `git log develop..HEAD` to get the commit list
1515
2. Run `git diff develop...HEAD` to understand all changes
16-
3. Draft the PR title and body
16+
3. Draft the PR title and body following the template below
1717
4. Confirm with the user, then run `gh pr create`
1818

19-
## PR Body Template
19+
## PR Title Format
20+
21+
```
22+
[type] 한국어로 간결하게 (70자 이내)
23+
```
24+
25+
## PR Body Template (must follow exactly)
2026

2127
```markdown
22-
## Summary
23-
- (key changes as bullet points)
28+
## 💡 PR 요약
29+
30+
> 해당 PR의 변경사항, 해당 이슈 등에 대한 간략한 설명을 작성해주세요.
31+
32+
- {변경사항을 bullet point로 작성}
33+
34+
## 📋 작업 내용
35+
36+
> 해당 PR에서 작업한 내용을 자세히 설명해주세요.
37+
38+
{구체적인 작업 내용 작성}
39+
40+
## 🤝 리뷰 시 참고사항
2441

25-
## Test plan
26-
- [ ] (test item 1)
27-
- [ ] (test item 2)
42+
> 리뷰어분들이 리뷰를 할 때 참고하면 좋을 사항이나 질문사항을 작성해주세요.
2843
29-
🤖 Generated with [Claude Code](https://claude.com/claude-code)
44+
{참고사항이 없으면 이 섹션 삭제}
3045
```
3146

3247
## Title Examples
3348

3449
```
35-
[feat] add validation to sign-in form
36-
[fix] prevent infinite redirect on token expiry
37-
[test] add auth unit tests
38-
[chore] add GitHub Actions CI configuration
50+
[feat] 로그인 폼 유효성 검사 추가
51+
[fix] 토큰 만료 시 무한 리다이렉트 수정
52+
[test] auth 관련 단위 테스트 추가
53+
[chore] GitHub Actions CI 설정 추가
3954
```

.claude/commands/resolve.md

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
Read all open PR review comments and post a reply to each thread: $ARGUMENTS
22

3+
## Rules
4+
5+
- **All replies must be written in Korean**
6+
- Be concise and clear — include the commit hash when referencing a fix
7+
38
## Instructions
49

510
1. Accept a PR number as argument, or auto-detect from the current branch
@@ -13,22 +18,24 @@ Read all open PR review comments and post a reply to each thread: $ARGUMENTS
1318
```
1419

1520
3. Classify each comment into one of:
16-
- **Done**: feedback already reflected in the code
17-
- **Pending**: fix required — describe the approach
18-
- **Skipped**: out of scope or disagreed — explain clearly with an alternative if available
21+
- **반영 완료**: 이미 코드에 반영된 피드백
22+
- **반영 예정**: 수정이 필요한 피드백
23+
- **스킵**: 범위 밖이거나 동의하지 않는 피드백
1924

2025
4. Post a reply to each comment thread
2126
```bash
2227
gh api repos/{owner}/{repo}/pulls/comments/{comment_id}/replies \
23-
-X POST -f body="<reply body>"
28+
-X POST -f body="<한국어 답글>"
2429
```
2530

2631
## Reply Guidelines
2732

28-
- **Done**: describe what was changed + include the commit hash
29-
- e.g. `Added clearAllCookies() helper and called it in beforeEach. (f812496)`
30-
- **Pending**: explain the planned fix and expected timing
31-
- **Skipped**: state the reason clearly; offer an alternative if applicable
33+
- **반영 완료**: 어떻게 수정했는지 + 커밋 해시 포함
34+
- 예: "`clearAllCookies()` 헬퍼를 추가하고 `beforeEach`에서 호출하도록 수정했습니다. (f812496)"
35+
- **반영 예정**: 수정 방향과 이유 설명
36+
- 예: "다음 커밋에서 `setLocationSearch()` 헬퍼로 추출하겠습니다."
37+
- **스킵**: 이유를 명확하게, 대안이 있으면 함께 제시
38+
- 예: "해당 부분은 Next.js 빌드 산출물 수준으로 판단해 테스트 범위에서 제외했습니다."
3239

3340
## Usage
3441

0 commit comments

Comments
 (0)