Skip to content

Commit 016572f

Browse files
liangxuZhangzhangliangxu3
andauthored
[fsdp] fix: Handle different transformers versions for Vision2Seq models in FSDP model merger (verl-project#5108)
### What does this PR do? Transformers versions 4.54 and later use the AutoModelForImageTextToText class to load multimodal models, therefore a condition should be added to the model merger in FSDP. > Add **concise** overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review. ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [ ] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`. Co-authored-by: zhangliangxu3 <zhangliangxu3@jd.com>
1 parent 96e3b42 commit 016572f

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

verl/model_merger/base_model_merger.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
AutoConfig,
2525
AutoModelForCausalLM,
2626
AutoModelForTokenClassification,
27-
AutoModelForVision2Seq,
2827
GenerationConfig,
2928
)
3029

@@ -202,7 +201,20 @@ def get_transformers_auto_model_class(self):
202201
case "AutoModelForTokenClassification":
203202
return AutoModelForTokenClassification
204203
case "AutoModelForVision2Seq":
205-
return AutoModelForVision2Seq
204+
# Handle different transformers versions for Vision2Seq models
205+
import transformers
206+
from packaging import version
207+
208+
if version.parse(transformers.__version__) >= version.parse("4.54.0"):
209+
# transformers >= 4.54.0 uses AutoModelForImageTextToText
210+
from transformers import AutoModelForImageTextToText
211+
212+
return AutoModelForImageTextToText
213+
else:
214+
# transformers < 4.54.0 uses AutoModelForVision2Seq
215+
from transformers import AutoModelForVision2Seq
216+
217+
return AutoModelForVision2Seq
206218
case _:
207219
raise NotImplementedError(f"Unknown auto class {auto_class}")
208220
else:

0 commit comments

Comments
 (0)