Skip to content

Review slider contribution #4278

@larsrickert

Description

@larsrickert

Why?

We received a nice OnyxSlider contribution in #4245. We need to review it, provide feedback and eventually merge the component.

Design

#2111

Acceptance criteria

  • the slider contribution PR is reviewed + feedback is provided
  • the slider is merged into onyx

DEV handover checklist

Storybook

DEV handover done with: @ADD_DEV_NAME_HERE

Testing

  • covered by visual screenshot tests
  • covered by functional tests (Playwright or unit test)

Documentation

  • "New" badge in Storybook is added, see storybook-addon-tag-badges
  • auto-generated Storybook code snippets are checked
  • component status has been updated in the docs overview
  • updated version is released
  • updated documentation is deployed

Other

  • follow-up tickets were created if necessary (add links below)

UX handover checklist

UX handover done with: @ADD_UX_NAME_HERE

Naming is aligned with Figma

  • component name
  • which support components are used and how they are named
  • all property names and types

Implementation is checked

  • all features of Figma are implemented or a follow-up ticket is refined
  • skeleton
  • densities
  • light and dark mode
  • truncation
  • responsiveness / wrapping behavior
  • min / max width

Figma

  • Figma component is published

Documentation

  • Storybook category is aligned with Figma
  • Storybook examples are checked

Other

  • follow-up tickets were created if necessary (add links below)

Metadata

Metadata

Assignees

Labels

devRequires technical expertise

Type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions