Fix quality warnings (#86)

* Delete unused constructor from SpectralException

* Turn SpectralRunner into a light service by specifying it to run on project level

* Turn ProjectSettingsState into light service

* Format code

* Add changelog and bump version

Author: markbrockhoff

CHANGELOG.md

@@ -5,6 +5,12 @@
 
 ## [Unreleased]
 
+### Changed
+- Delete unused constructor from SpectralException
+- Turn SpectralRunner into a light service
+- Turn ProjectSettingsState into a light service
+- Reformat code
+
 ## [2.1.0] - 2023-08-02
 
 ### Changed

gradle.properties

@@ -3,7 +3,7 @@ pluginGroup=com.schwarzit.spectral-intellij-plugin
 pluginName=Spectral
 pluginRepositoryUrl=https://github.com/SchwarzIT/spectral-intellij-plugin
 # SemVer format -> https://semver.org
-pluginVersion=2.1.0
+pluginVersion=2.1.1
 # Supported build number ranges and IntelliJ Platform versions -> https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 pluginSinceBuild=222
 #pluginUntilBuild=231.*

src/main/kotlin/com/schwarzit/spectralIntellijPlugin/SpectralException.kt

@@ -2,6 +2,5 @@ package com.schwarzit.spectralIntellijPlugin
 
 class SpectralException : Exception {
     constructor(message: String) : super(message)
-    constructor(cause: Throwable) : super(cause)
     constructor(message: String, cause: Throwable) : super(message, cause)
 }

src/main/kotlin/com/schwarzit/spectralIntellijPlugin/SpectralExternalAnnotator.kt

@@ -18,12 +18,12 @@ import org.jetbrains.yaml.psi.YAMLFile
 import java.nio.file.FileSystems
 import java.nio.file.Paths
 
-class SpectralExternalAnnotator : ExternalAnnotator<Pair<PsiFile,Editor>, List<SpectralIssue>>() {
+class SpectralExternalAnnotator : ExternalAnnotator<Pair<PsiFile, Editor>, List<SpectralIssue>>() {
     companion object {
         val logger = getLogger()
     }
 
-    override fun collectInformation(file: PsiFile, editor: Editor, hasErrors: Boolean): Pair<PsiFile,Editor>? {
+    override fun collectInformation(file: PsiFile, editor: Editor, hasErrors: Boolean): Pair<PsiFile, Editor>? {
         if (file !is JsonFile && file !is YAMLFile) return null
 
         try {
@@ -52,7 +52,7 @@ class SpectralExternalAnnotator : ExternalAnnotator<Pair<PsiFile,Editor>, List<S
         return fileMatcher.matches(file.virtualFile.toNioPath())
     }
 
-    override fun doAnnotate(info: Pair<PsiFile,Editor>): List<SpectralIssue> {
+    override fun doAnnotate(info: Pair<PsiFile, Editor>): List<SpectralIssue> {
         val progressManager = ProgressManager.getInstance()
         val computable = Computable { lintFile(info.second) }
         val indicator = BackgroundableProcessIndicator(

src/main/kotlin/com/schwarzit/spectralIntellijPlugin/SpectralRunner.kt

@@ -12,7 +12,7 @@ import java.text.ParseException
 import java.time.Duration
 import java.util.concurrent.ExecutionException
 
-@Service
+@Service(Service.Level.PROJECT)
 class SpectralRunner(private val project: Project) {
     companion object {
         private val logger = getLogger()

src/main/kotlin/com/schwarzit/spectralIntellijPlugin/settings/ProjectSettingsState.kt

@@ -1,6 +1,7 @@
 package com.schwarzit.spectralIntellijPlugin.settings
 
 import com.intellij.openapi.components.PersistentStateComponent
+import com.intellij.openapi.components.Service
 import com.intellij.openapi.components.State
 import com.intellij.openapi.components.Storage
 import com.intellij.util.xmlb.XmlSerializerUtil
@@ -9,6 +10,7 @@ import com.intellij.util.xmlb.XmlSerializerUtil
     name = "com.schwarzit.spectralIntellijPlugin.settings.ProjectSettingsState",
     storages = [Storage("spectral.xml")]
 )
+@Service(Service.Level.PROJECT)
 class ProjectSettingsState : PersistentStateComponent<ProjectSettingsState> {
 
     var ruleset: String = "https://raw.githubusercontent.com/SchwarzIT/api-linter-rules/main/spectral-api.yml"

src/main/resources/META-INF/plugin.xml

@@ -3,7 +3,7 @@
     <id>com.schwarzit.spectral-intellij-plugin</id>
     <name>Spectral</name>
     <vendor>SchwarzIT</vendor>
-    
+
     <depends>com.intellij.modules.platform</depends>
     <depends>org.jetbrains.plugins.yaml</depends>
 
@@ -21,6 +21,5 @@
                              instance="com.schwarzit.spectralIntellijPlugin.settings.ProjectSettingsConfigurable"
                              id="com.schwarzit.spectralIntellijPlugin.settings.ProjectSettingsConfigurable"
                              displayName="Spectral" nonDefaultProject="true"/>
-        <projectService serviceImplementation="com.schwarzit.spectralIntellijPlugin.settings.ProjectSettingsState"/>
     </extensions>
 </idea-plugin>