Skip to content

ConfigurableActions isVisible condition wrong #2133

@belfhi

Description

@belfhi

Summary

The configurable actions component is meant to be a general purpose component
which can be reused in multiple places.
The appConfig includes multiple switches datasetActionsEnabled, datafilesActionsEnabled, datasetDetailsActionsEnabled and datasetSelectionActionsEnabled.
While currently only datasetActions and datafilesActions are implemented,
the isVisible function of the component depends only on datafilesActionsEnabled,
which means if only datasetActionsEnabled is true, the component is not rendered.
See line 19 in the code:

return this.appConfigService.getConfig().datafilesActionsEnabled;

Steps to Reproduce

set datasetActionsEnabled: true and datafilesActionsEnabled: false in the frontend config

Current Behaviour

the datasetActions component(s) are not rendered

Expected Behaviour

the switch datasetActionsEnabled should enable the component even if datafilesActions are disabled.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions