fix: remove default values in DTOs that cause value overwrite on update (#1802)

<!--
Follow semantic-release guidelines for the PR title, which is used in
the changelog.

Title should follow the format `<type>(<scope>): <subject>`, where
- Type is one of:
build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|BREAKING
CHANGE
- Scope (optional) describes the place of the change (eg a particular
milestone) and is usually omitted
- subject should be a non-capitalized one-line description in present
imperative tense and not ending with a period

See
https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines
for more details.
-->

## Description
This PR aims to fix the `size` and `numberOfFiles` fields overwrite in
the partial update of a dataset.

## Motivation
`size` and `numberOfFiles` fields were overwritten every time when a
partial update on a dataset was performed.

## Fixes
<!-- Please provide a list of the issues fixed by this PR -->

* #1688

## Changes:
<!-- Please provide a list of the changes implemented by this PR -->

* changes made

## Tests included

- [x] Included for each change/fix?
- [x] Passing? <!-- Merge will not be approved unless tests pass -->

## Documentation
- [ ] swagger documentation updated (required for API changes)
- [ ] official documentation updated

### official documentation info
<!-- If you have updated the official documentation, please provide PR #
and URL of the updated pages -->

Author: nitrosx

src/datasets/dto/update-dataset-obsolete.dto.ts

@@ -96,7 +96,7 @@ export class UpdateDatasetObsoleteDto extends OwnableDto {
   })
   @IsOptional()
   @IsInt()
-  readonly size?: number = 0;
+  readonly size?: number;
 
   @ApiProperty({
     type: Number,
@@ -107,7 +107,7 @@ export class UpdateDatasetObsoleteDto extends OwnableDto {
   })
   @IsOptional()
   @IsInt()
-  readonly packedSize?: number = 0;
+  readonly packedSize?: number;
 
   @ApiProperty({
     type: Number,
@@ -118,7 +118,7 @@ export class UpdateDatasetObsoleteDto extends OwnableDto {
   })
   @IsOptional()
   @IsInt()
-  readonly numberOfFiles?: number = 0;
+  readonly numberOfFiles?: number;
 
   @ApiProperty({
     type: Number,
@@ -128,7 +128,7 @@ export class UpdateDatasetObsoleteDto extends OwnableDto {
   })
   @IsOptional()
   @IsInt()
-  readonly numberOfFilesArchived?: number = 0;
+  readonly numberOfFilesArchived?: number;
 
   @ApiProperty({
     type: Date,

src/proposals/dto/update-proposal.dto.ts

@@ -96,7 +96,7 @@ export class UpdateProposalDto extends OwnableDto {
    */
   @IsOptional()
   @IsObject()
-  readonly metadata?: Record<string, unknown> = {};
+  readonly metadata?: Record<string, unknown>;
 
   /**
    * Parent proposal id.

test/RawDatasetDatablock.js

@@ -13,7 +13,7 @@ describe("1800: RawDatasetDatablock: Test Datablocks and their relation to raw D
   before(() => {
     db.collection("Dataset").deleteMany({});
   });
-  beforeEach(async() => {
+  beforeEach(async () => {
     accessTokenAdminIngestor = await utils.getToken(appUrl, {
       username: "adminIngestor",
       password: TestData.Accounts["adminIngestor"]["password"],
@@ -59,6 +59,27 @@ describe("1800: RawDatasetDatablock: Test Datablocks and their relation to raw D
       });
   });
 
+  it("0021: partial update of the dataset should not overwrite the size and number of files", () => {
+    return request(appUrl)
+      .patch(`/api/v3/datasets/${datasetPid}`)
+      .send(TestData.PatchInstrument1)
+      .set("Accept", "application/json")
+      .set({ Authorization: `Bearer ${accessTokenAdminIngestor}` })
+      .expect(TestData.SuccessfulPatchStatusCode)
+      .expect("Content-Type", /json/)
+      .then((res) => {
+        res.body.should.have
+          .property("instrumentId")
+          .and.be.equal(TestData.PatchInstrument1["instrumentId"]);
+        res.body.should.have
+          .property("size")
+          .and.equal(TestData.DataBlockCorrect.size);
+        res.body.should.have
+          .property("numberOfFiles")
+          .and.equal(TestData.DataBlockCorrect.dataFileList.length);
+      });
+  });
+
   it("0030: adds the same datablock again which should fail because it is already stored", async () => {
     return request(appUrl)
       .post(`/api/v3/datasets/${datasetPid}/Datablocks`)