fix: samples count endpoint for frontend usability (#1923)

* fix: samples count endpoint for frontend usability

* fix the api query example

* fix lint warnings

Author: martin-trajanovski

src/common/types.ts

@@ -10,11 +10,6 @@ export class FullFacetFilters {
   fields?: string;
 }
 
-export class SampleCountFilters {
-  @ApiPropertyOptional()
-  fields?: string;
-}
-
 export class FullQueryFilters {
   @ApiPropertyOptional()
   limits?: string;

src/samples/samples.controller.ts

@@ -66,7 +66,7 @@ import { JWTUser } from "src/auth/interfaces/jwt-user.interface";
 import { IDatasetFields } from "src/datasets/interfaces/dataset-filters.interface";
 import { CreateSubAttachmentV3Dto } from "src/attachments/dto-obsolete/create-sub-attachment.v3.dto";
 import { AuthenticatedPoliciesGuard } from "src/casl/guards/auth-check.guard";
-import { CountApiResponse, SampleCountFilters } from "src/common/types";
+import { CountApiResponse } from "src/common/types";
 import { OutputAttachmentV3Dto } from "src/attachments/dto-obsolete/output-attachment.v3.dto";
 
 export class FindByIdAccessResponse {
@@ -340,11 +340,11 @@ export class SamplesController {
       "It returns a number of samples matching the where filter if provided.",
   })
   @ApiQuery({
-    name: "filter",
+    name: "fields",
     description: "Database filters to apply when retrieve samples count",
     required: false,
-    type: SampleCountFilters,
-    example: `{fields: ${samplesFullQueryExampleFields}}`,
+    type: String,
+    example: samplesFullQueryExampleFields,
   })
   @ApiResponse({
     status: HttpStatus.OK,