Job Action: Switch

[despadam]

From #1124

Filters (eg different actions depending on the status, storing to different location)

For OpenEM project: Filters to be implemented later, when ETH is also onboarded.

[sbliven]

I've been thinking about the config option syntax for this. Does this look reasonable? Any options on the spellings (eg switch vs filter)?

- actionType: switch
  # Either 'request' or 'datasets', analogous to validateaction
  scope: datasets
  # JSONPath to extract the value from the given scope
  property: datasetlifecycle.storageLocation
  # Cases are tested sequentially, with the first match applied (no fallthrough)
  cases:
      # match applies a regex. Assumes the property is a string
    - match: /PSI.*/i
      actions:
      - actionType: log
        performJob: "Sending job to PSI"
      # schema applies an AJV schema
    - schema:
        const: ETHZ
      actions:
      - actionType: log
        performJob: "Sending job to ETHZ"
      # default case (no match or schema)
    - actions:
      - actionType: error
        code: 400
        message: Invalid storageLocation

[despadam]

Looks reasonable to me.
I like the action name switch - I think filter can be a bit misleading. Perhaps could even be switchLocation, to make it even clearer?

[sbliven]

I ran into an issue while writing tests. Currently we have two scopes, request and datasets, which provide the property for the switch test. However, actions run two stages, validate(dto) and performAction(job). Should the switch test be applied twice, once in the dto and once on the job? This would limit the test to properties that are present in both dto and job (although this includes most useful properties). Or should the switch have separate scopes for validate and perform phases, requiring that part of the config file to get duplicated?