Commit f99a4a4
Migrate run_qa to SciMLTesting 1.5 minimal form
SciMLTesting 1.5.0 makes Aqua and ExplicitImports its own direct deps and
auto-detects them, with JET still a weakdep (opt-in via `using JET`).
`explicit_imports` stays an explicit opt-in (defaults false).
- test/qa/qa.jl: collapse to the minimal form. Imports become
`using SciMLTesting, ADTypes, Test` + `using JET`; drop `using Aqua` and
`using ExplicitImports`. The run_qa call drops the now-auto-detected
`Aqua = Aqua`, `JET = JET`, `jet = true`, and `ExplicitImports = ExplicitImports`
module args, keeping only the genuine per-repo overrides
(aqua_kwargs, jet_kwargs, explicit_imports = true, ei_kwargs).
- test/qa/Project.toml: drop ExplicitImports from [deps]/[compat] (now
transitive via SciMLTesting); bump SciMLTesting compat to 1.5. Aqua is kept
as a direct dep on purpose: Aqua's ambiguity check spawns a worker
subprocess that runs a bare `using Aqua` against the active project, which
errors ("Package Aqua not found in current path") if Aqua is only a
transitive (manifest-only) dep. JET is kept (the qa runs JET).
- Project.toml: bump SciMLTesting compat to 1.5.
Verified locally against the released SciMLTesting 1.5.0 (Pkg-resolved, no
dev-from-branch): QA group 17/17 on Julia 1.10 and 1.11, running the same
checks as before — all Aqua checks (incl. Method ambiguity), the six
ExplicitImports checks, and JET.test_package.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 85ab740 commit f99a4a4
3 files changed
Lines changed: 9 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | | - | |
17 | 15 | | |
18 | 16 | | |
19 | | - | |
| 17 | + | |
20 | 18 | | |
21 | 19 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
| 2 | + | |
7 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | | - | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | 12 | | |
15 | | - | |
16 | 13 | | |
17 | 14 | | |
18 | 15 | | |
| |||
0 commit comments