Skip to content

Commit f99a4a4

Browse files
Migrate run_qa to SciMLTesting 1.5 minimal form
SciMLTesting 1.5.0 makes Aqua and ExplicitImports its own direct deps and auto-detects them, with JET still a weakdep (opt-in via `using JET`). `explicit_imports` stays an explicit opt-in (defaults false). - test/qa/qa.jl: collapse to the minimal form. Imports become `using SciMLTesting, ADTypes, Test` + `using JET`; drop `using Aqua` and `using ExplicitImports`. The run_qa call drops the now-auto-detected `Aqua = Aqua`, `JET = JET`, `jet = true`, and `ExplicitImports = ExplicitImports` module args, keeping only the genuine per-repo overrides (aqua_kwargs, jet_kwargs, explicit_imports = true, ei_kwargs). - test/qa/Project.toml: drop ExplicitImports from [deps]/[compat] (now transitive via SciMLTesting); bump SciMLTesting compat to 1.5. Aqua is kept as a direct dep on purpose: Aqua's ambiguity check spawns a worker subprocess that runs a bare `using Aqua` against the active project, which errors ("Package Aqua not found in current path") if Aqua is only a transitive (manifest-only) dep. JET is kept (the qa runs JET). - Project.toml: bump SciMLTesting compat to 1.5. Verified locally against the released SciMLTesting 1.5.0 (Pkg-resolved, no dev-from-branch): QA group 17/17 on Julia 1.10 and 1.11, running the same checks as before — all Aqua checks (incl. Method ambiguity), the six ExplicitImports checks, and JET.test_package. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 85ab740 commit f99a4a4

3 files changed

Lines changed: 9 additions & 14 deletions

File tree

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ ChainRulesCore = "1.0.2"
1818
ConstructionBase = "1.5"
1919
EnzymeCore = "0.5.3,0.6,0.7,0.8"
2020
SafeTestsets = "0.1, 1"
21-
SciMLTesting = "1.4"
21+
SciMLTesting = "1.5"
2222
julia = "1.10"
2323

2424
[extras]

test/qa/Project.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
[deps]
22
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
33
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
4-
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
54
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
65
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
76
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
@@ -13,9 +12,8 @@ ADTypes = {path = "../.."}
1312
[compat]
1413
ADTypes = "1"
1514
Aqua = "0.8"
16-
ExplicitImports = "1.11"
1715
JET = "0.9, 0.10, 0.11"
1816
SafeTestsets = "0.1, 1"
19-
SciMLTesting = "1.4"
17+
SciMLTesting = "1.5"
2018
Test = "1"
2119
julia = "1.10"

test/qa/qa.jl

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
1-
using ADTypes
2-
using Aqua: Aqua
3-
using ExplicitImports: ExplicitImports
4-
using JET: JET
5-
using SciMLTesting: run_qa
6-
using Test
1+
using SciMLTesting, ADTypes, Test
2+
using JET
73

4+
# Aqua and ExplicitImports are SciMLTesting deps, so they are not imported here.
5+
# Aqua is still listed in this env's `[deps]` (not ExplicitImports): Aqua's ambiguity
6+
# check spawns a worker subprocess that runs a bare `using Aqua` against the active
7+
# project, which only resolves if Aqua is a *direct* dep — a transitive (manifest-only)
8+
# Aqua makes that worker error with "Package Aqua not found in current path".
89
run_qa(
910
ADTypes;
10-
Aqua = Aqua,
1111
aqua_kwargs = (; deps_compat = (; check_extras = false)),
12-
JET = JET,
13-
jet = true,
1412
jet_kwargs = (; target_defined_modules = true),
15-
ExplicitImports = ExplicitImports,
1613
explicit_imports = true,
1714
# Two unavoidable non-public `Base` names, ignored only in the public-API access
1815
# check (every other ExplicitImports check passes unignored):

0 commit comments

Comments
 (0)