Default `AutoMooncake`?

[MilesCranmer]

The AutoMooncake docs state:

• config: either nothing or an instance of Mooncake.Config -- see the docstring of Mooncake.Config for more information. AutoMooncake(; config=nothing) is equivalent to AutoMooncake(; config=Mooncake.Config()), i.e. the default configuration.

so can config=nothing be the default? Why do I need to explicitly write config=nothing?

@gdalle

[gdalle]

This was a decision by @willtebbutt to force people to explicitly think about the config. I'm not a fan either, perhaps we could revisit it?

[willtebbutt]

I'm open to revisiting -- with the benefit of hindsight, I agree that the value it adds is limited, and it's quite annoying to have to type it out.

[gdalle]

@MilesCranmer wanna do the honors?

[MilesCranmer]

In case it helps with the design decision, I can share that I have typed out AutoMooncake(; config=nothing) maybe a hundred times and haven't once looked into what else could go there.

I kept running through a cycle of (1) hitting this confusing error:

julia> AutoMooncake()
ERROR: UndefKeywordError: keyword argument `config` not assigned
Stacktrace:
 [1] AutoMooncake()

and then (2) needing to go to the DI docs to see what to put there, and (3) feeling relief/surprise that I could just put nothing and get on with it – which I did without further exploration, being the impatient user I am. After the first ~5 or so errors it just became muscle memory and I forgot about it.

From an ergonomics perspective I think making it work out of the box is always nice. Then if I need to I can go read about it.

@gdalle please feel free to go ahead!

[gdalle]

Yeah I just meant do you want to open a 2-line PR to ADTypes acting on your proposed change to set a default value for config and document it? I'm already convinced ^^ Otherwise I'll do it when I get back to my laptop

[MilesCranmer]

Yes, sorry, I am subtly passing the buck back to you. (Am in the middle of something and trying to not get too off track... even filing the issue was a bit risky for me... sorry! 😀 )

[MilesCranmer]

(am about 3 levels deep into a yak shave... trying my best to avoid 4)