Skip to content

Modeling test group fails on current master #1502

Description

@ChrisRackauckas-Claude

Current origin/master test reproduction shows two blockers in the Modeling test group.

Reproduction environment:

git worktree add --detach ../Catalyst_master_check origin/master
cd ../Catalyst_master_check
timeout 3600 env GROUP=Modeling ~/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()'

The first blocker is an unexpected pass:

ReactionSystem Structure: Error During Test at test/reactionsystem_core/reactionsystem.jl:1150
 Unexpected Pass
 Expression: ModelingToolkitBase.getmetadata(complete(rs2), MiscSystemData, nothing) == ones(2, 3)
 Got correct result, please change to @test if no longer broken.

After temporarily changing only that stale @test_broken to @test in the disposable worktree so the suite can continue, the same command reaches DSL Options and fails:

Test Summary: | Pass  Fail  Broken  Total
DSL Options   |  308     9       1    318

Observed failing DSL assertions include:

test/dsl/dsl_options.jl:793   issetequal(parameters(rs), [k, k_obs, k_ratio, eps_val])
test/dsl/dsl_options.jl:1187  Catalyst.isequivalent(rs_dsl, rs_prog)
test/dsl/dsl_options.jl:1260  Catalyst.isequivalent(rs_multi, rs_multi_prog)
test/dsl/dsl_options.jl:1274  Catalyst.isequivalent(rs_sum, rs_sum_prog)
test/dsl/dsl_options.jl:1287  Catalyst.isequivalent(rs_fun, rs_fun_prog)
test/dsl/dsl_options.jl:1303  Catalyst.isequivalent(rs_indexed, rs_indexed_prog)
test/dsl/dsl_options.jl:1956  Catalyst.isequivalent(rn_dsl, rn_prog)
test/dsl/dsl_options.jl:1974  Catalyst.isequivalent(rn_dsl, rn_prog)
test/dsl/dsl_options.jl:1992  Catalyst.isequivalent(rn_dsl, rn_prog)

I hit this while verifying an unrelated documentation-only PR. I did not include fixes there because these failures reproduce on origin/master.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions