Fix Basis compatibility with ODEProblem #553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #552 where using a
Basisobject obtained from DMD or SINDy as the ODE function inODEProblemwould throw an error about the 'observed' field not existing.Changes
Basisin new filesrc/basis/modelingtoolkit_interface.jlAbstractSysteminterface methods:equationsunknownsparametersget_observedget_ivnameofgetpropertyto properly handle:observedfield accessshowmethod to fix display error related to namespacing flagTest plan
[x] Tested with the MRE from issue #552
[x] All existing package tests pass
[x] Both reported issues (ODEProblem creation and display) are fixed
Fixes #552
🤖 Generated with Claude Code