Skip to content

Commit d8daeb4

Browse files
Apply suggestions from code review
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
1 parent e1c570d commit d8daeb4

6 files changed

Lines changed: 8 additions & 25 deletions

File tree

docs/src/basics/solution.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ The solution interface also includes some special fields. The problem object
151151
`prob` and the algorithm used to solve the problem `alg` are included in the
152152
solution. Additionally, the field `dense` is a boolean which states whether
153153
the interpolation functionality is available. Further, the field `stats`
154-
(formerly `destats`, renamed in SciMLBase v3) contains the internal statistics
154+
contains the internal statistics
155155
for the solution process, such as the number of linear solves and convergence
156156
failures. Lastly, there is a mutable state `tslocation` which controls the
157157
plot recipe behavior. By default, `tslocation=0`.

docs/src/features/io.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ df = DataFrames.DataFrame(sol)
2121
```
2222

2323
If we attach an ModelingToolkit / SciML symbolic system via the problem's
24-
`sys`, then those names will be used (the old `syms`/`paramsyms`/`indepsym`
25-
kwargs on `ODEFunction` were removed in SciMLBase v3; use the symbolic
26-
interface instead):
24+
`sys`, then those names will be used:
2725

2826
```@example IO
2927
df = DataFrames.DataFrame(sol)

docs/src/features/linear_nonlinear.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ on the choices.
3737
## Preconditioners: `precs` Specification
3838

3939
Any [LinearSolve.jl-compatible preconditioner](https://docs.sciml.ai/LinearSolve/stable/basics/Preconditioners/)
40-
can be used as a left or right preconditioner. Starting with OrdinaryDiffEq
41-
v7 / DiffEqBase v7, the per-solver `precs` kwarg and the old `DEFAULT_PRECS`
42-
default were removed — preconditioners are now configured on the `linsolve`
40+
can be used as a left or right preconditioner. Preconditioners are configured on the `linsolve`
4341
object itself, through LinearSolve's `Pl` / `Pr` interface. For example:
4442

4543
```julia

docs/src/features/performance_overloads.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@ of pre-computed functions to speed up the calculations. This is offered via the
1717

1818
All applicable stiff differential equation solvers in the Julia ecosystem
1919
(OrdinaryDiffEq.jl, StochasticDiffEq.jl, DelayDiffEq.jl, etc.) take an
20-
`autodiff` keyword for handling automatic Jacobian construction. Starting with
21-
OrdinaryDiffEq v7 / SciMLBase v3 this takes an `ADTypes` object rather than a
22-
`Bool`, which means every AD backend in the Julia ecosystem is supported
20+
`autodiff` keyword for handling automatic Jacobian construction. This takes an `ADTypes` object,
21+
which means every AD backend in the Julia ecosystem is supported
2322
through the same interface:
2423

2524
- `autodiff`: Specifies the AD backend to use for Jacobian / gradient
@@ -34,10 +33,6 @@ through the same interface:
3433
`nothing`, which means it will be chosen true/false depending on circumstances
3534
of the solver, such as whether a Krylov subspace method is used for `linsolve`.
3635

37-
The old solver kwargs `chunk_size`, `diff_type`, and `standardtag` were
38-
removed in OrdinaryDiffEq v7 — the first two are now configured on the
39-
`ADTypes` object (`AutoForwardDiff(chunksize=…)` /
40-
`AutoFiniteDiff(fdtype=…)`) and the latter is always on.
4136

4237
## Passing Jacobian Function Definitions
4338

docs/src/solvers/ode_solve.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,6 @@ These methods when lazy assume that the parameter vector `p` will be unchanged
207207
between the moment of the interval solving and the interpolation. If `p` is
208208
changed in a ContinuousCallback, or in a DiscreteCallback and the continuous
209209
solution is used after the full solution, then set `lazy=Val{false}()`.
210-
Starting with OrdinaryDiffEq v7 this kwarg must be a `Val{Bool}` rather than
211-
a raw `Bool`.
212210

213211
Example:
214212

@@ -806,9 +804,6 @@ alg = ExplicitRK(tableau = OrdinaryDiffEqExplicitTableaus.DormandPrince())
806804
solve(prob, alg)
807805
```
808806

809-
(The `construct*` prefix on the tableau constructors was dropped in
810-
OrdinaryDiffEq v7; the new names live in `OrdinaryDiffEqExplicitTableaus` /
811-
`OrdinaryDiffEqImplicitTableaus` and are no longer exported.)
812807

813808
#### CompositeAlgorithm
814809

@@ -1252,11 +1247,9 @@ import NeuralPDE
12521247

12531248
### List of Supplied Tableaus
12541249

1255-
A large variety of tableaus have been supplied by default. Starting with
1256-
OrdinaryDiffEq v7 / DiffEqDevTools v3 these live in
1250+
A large variety of tableaus have been supplied by default. These live in
12571251
`OrdinaryDiffEqExplicitTableaus` / `OrdinaryDiffEqImplicitTableaus` under
1258-
their bare names (no `construct` prefix), and are no longer exported — call
1259-
them qualified. The list of tableaus can be found in
1252+
their bare names. The list of tableaus can be found in
12601253
[the developer docs](https://docs.sciml.ai/DiffEqDevDocs/stable/internals/tableaus/).
12611254
To use them:
12621255

docs/src/tutorials/advanced_ode_example.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,7 @@ valid [LinearSolve.jl](https://docs.sciml.ai/LinearSolve/stable/) solver.
225225
## Adding a Preconditioner
226226

227227
Any [LinearSolve.jl-compatible preconditioner](https://docs.sciml.ai/LinearSolve/stable/basics/Preconditioners/)
228-
can be used as a preconditioner in the linear solver interface. Starting with
229-
OrdinaryDiffEq v7 / DiffEqBase v7, the `precs` keyword is on the
228+
can be used as a preconditioner in the linear solver interface. The `precs` keyword is on the
230229
LinearSolve.jl linear solver object (e.g. `KrylovJL_GMRES(precs = ...)`)
231230
rather than on the ODE algorithm, and the `precs` callback signature is
232231
`Pl, Pr = precs(A, p)` — where `A` is the current `W = I - γJ` operator and

0 commit comments

Comments
 (0)