-
-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Description
Issue
The Downgrade CI workflow uses julia-downgrade-compat to test against minimum compatible versions of dependencies. With the change in #244 making Optim a weak dependency (extension), the downgrade CI behavior may need adjustment.
Background
PR #244 moves Optim from [deps] to [weakdeps] with a package extension. The current Downgrade workflow in .github/workflows/Downgrade.yml uses julia-actions/julia-downgrade-compat@v2 which downgrades all dependencies to their minimum compatible versions.
Potential issues
- The downgrade action may not properly handle weak dependencies/extensions
- The extension tests require Optim to be loaded, but the downgrade behavior for weak deps may differ
- The
skipparameter in the workflow currently only skipsPkg,TOML
Suggested resolution
Consider one of:
- Adding
Optimto the skip list in the Downgrade workflow - Verifying that
julia-downgrade-compatproperly handles weak dependencies - Updating the test targets to ensure Optim is properly loaded during downgrade tests
Related
- PR Make Optim an extension package #244 - Make Optim an extension package
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels