Skip to content

Niche case of remake with symbol map and static array fail #4098

@TorkelE

Description

@TorkelE
using ModelingToolkitBase, StaticArrays, OrdinaryDiffEqDefault
using ModelingToolkitBase: t_nounits as t, D_nounits as D
@parameters p d
@variables X(t)
eqs = [D(X) ~ p - d*X]
@mtkbuild sys = System(eqs, t)

sim_cond = SA[:X => 1.0, :p => 2.0, :d => 0.1]
oprob = ODEProblem(sys, sim_cond, (0.0, 1.0))
remake(oprob; p = [:p => 2.0, :d => 0.1]) # fine
remake(oprob; p = SA[:p => 2.0, :d => 0.1])
ERROR: TypeError: :p is not a valid key for type SymbolicUtils.BasicSymbolicImpl.var"typeof(BasicSymbolicImpl)"{SymReal}
Stacktrace:
 [1] setindex!(h::Dict{…}, v0::Float64, key0::Symbol)
   @ Base .\dict.jl:348
 [2] Dict{…}(kv::SVector{…})
   @ Base .\dict.jl:94
 [3] remake_initialization_data(sys::System, odefn::ODEFunction{…}, u0::Missing, t0::Float64, p::SVector{…}, newu0::SVector{…}, newp::MTKParameters{…})
   @ ModelingToolkitBase C:\Users\Torkel\.julia\packages\ModelingToolkitBase\fjBdh\src\systems\nonlinear\initializesystem.jl:560
 [4] remake(prob::ODEProblem{…}; f::Missing, u0::Missing, tspan::Missing, p::SVector{…}, kwargs::Missing, interpret_symbolicmap::Bool, build_initializeprob::Type, use_defaults::Bool, lazy_initialization::Nothing, _kwargs::@Kwargs{})
   @ SciMLBase C:\Users\Torkel\.julia\packages\SciMLBase\4MHGc\src\remake.jl:237

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions