Skip to content

Commit 4deb290

Browse files
Widen RKN endpoint atol and Vern7 DDE error threshold for CVHin
RKN nystrom_convergence_tests.jl: Add atol=1e-4 to endpoint comparisons for adaptive IIP vs OOP tests. The different initial steps from CVHin cause solutions to diverge at ~1e-6 level by t=10, exceeding default isapprox tolerance. DelayDiffEq verner.jl: Widen Vern7 final error threshold from 3.5e-7 to 5.0e-7 (observed 4.22e-7 with CVHin initial step). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent 834b983 commit 4deb290

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

lib/DelayDiffEq/test/integrators/verner.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ using Test
3131
sol_ip = solve(prob_ip, alg)
3232

3333
@test sol_ip.errors[:l∞] < 6.0e-4
34-
@test sol_ip.errors[:final] < 3.5e-7
34+
@test sol_ip.errors[:final] < 5.0e-7
3535
@test sol_ip.errors[:l2] < 3.0e-4
3636

3737
sol_scalar = solve(prob_scalar, alg)

lib/OrdinaryDiffEqRKN/test/nystrom_convergence_tests.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ end
416416
# due to FP rounding differences in initdt and step controller
417417
sol_i = solve(ode_i, alg)
418418
sol_o = solve(ode_o, alg)
419-
@test sol_i.u[end] sol_o.u[end]
419+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
420420
end
421421

422422
@testset "FineRKN5" begin
@@ -435,7 +435,7 @@ end
435435
# adaptive time step — IIP vs OOP may produce different step counts
436436
sol_i = solve(ode_i, alg)
437437
sol_o = solve(ode_o, alg)
438-
@test sol_i.u[end] sol_o.u[end]
438+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
439439
end
440440

441441
@testset "DPRKN4" begin
@@ -454,7 +454,7 @@ end
454454
# adaptive time step — IIP vs OOP may produce different step counts
455455
sol_i = solve(ode_i, alg)
456456
sol_o = solve(ode_o, alg)
457-
@test sol_i.u[end] sol_o.u[end]
457+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
458458
end
459459

460460
@testset "DPRKN5" begin
@@ -473,7 +473,7 @@ end
473473
# adaptive time step — IIP vs OOP may produce different step counts
474474
sol_i = solve(ode_i, alg)
475475
sol_o = solve(ode_o, alg)
476-
@test sol_i.u[end] sol_o.u[end]
476+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
477477
end
478478

479479
@testset "DPRKN6" begin
@@ -492,7 +492,7 @@ end
492492
# adaptive time step — IIP vs OOP may produce different step counts
493493
sol_i = solve(ode_i, alg)
494494
sol_o = solve(ode_o, alg)
495-
@test sol_i.u[end] sol_o.u[end]
495+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
496496
end
497497

498498
@testset "DPRKN6FM" begin
@@ -511,7 +511,7 @@ end
511511
# adaptive time step — IIP vs OOP may produce different step counts
512512
sol_i = solve(ode_i, alg)
513513
sol_o = solve(ode_o, alg)
514-
@test sol_i.u[end] sol_o.u[end]
514+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
515515
end
516516

517517
@testset "DPRKN8" begin
@@ -530,7 +530,7 @@ end
530530
# adaptive time step — IIP vs OOP may produce different step counts
531531
sol_i = solve(ode_i, alg)
532532
sol_o = solve(ode_o, alg)
533-
@test sol_i.u[end] sol_o.u[end]
533+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
534534
end
535535

536536
@testset "DPRKN12" begin
@@ -549,6 +549,6 @@ end
549549
# adaptive time step — IIP vs OOP may produce different step counts
550550
sol_i = solve(ode_i, alg)
551551
sol_o = solve(ode_o, alg)
552-
@test sol_i.u[end] sol_o.u[end]
552+
@test sol_i.u[end] sol_o.u[end] atol = 1.0e-4
553553
end
554554
end

0 commit comments

Comments
 (0)