Skip to content

Commit 869835b

Browse files
Fix: remove matrix exclude (incompatible with include-only matrices)
GitHub Actions exclude doesn't work with include-only matrices and silently prevents job creation. Move the BDF pre-release exclusion into the Julia script's EXCLUDES set instead. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c54d7a8 commit 869835b

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.github/scripts/compute_affected_sublibraries.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,13 @@ function compute_affected(changed_files::Vector{String},
128128
return affected
129129
end
130130

131+
# Entries to exclude from the matrix.
132+
# Each entry is (group, version) where group is the CI GROUP string.
133+
# See: https://github.com/SciML/OrdinaryDiffEq.jl/issues/2977
134+
const EXCLUDES = Set([
135+
("OrdinaryDiffEqBDF", "pre"), # JET resolution fails on pre-release Julia
136+
])
137+
131138
function build_matrix(affected::Set{String}, lib_dir::String)
132139
entries = Vector{@NamedTuple{group::String, version::String}}()
133140
for pkg in sort!(collect(affected))
@@ -137,6 +144,7 @@ function build_matrix(affected::Set{String}, lib_dir::String)
137144
# All other groups append _GROUPNAME (e.g., OrdinaryDiffEqCore_QA)
138145
ci_group = group_name == "Core" ? pkg : "$(pkg)_$(group_name)"
139146
for ver in versions
147+
(ci_group, ver) in EXCLUDES && continue
140148
push!(entries, (; group = ci_group, version = ver))
141149
end
142150
end

.github/workflows/SublibraryCI.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ jobs:
5959
fail-fast: false
6060
matrix:
6161
include: ${{ fromJson(needs.detect-changes.outputs.matrix) }}
62-
exclude:
63-
# Skip OrdinaryDiffEqBDF on pre-release Julia (JET resolution fails)
64-
# See: https://github.com/SciML/OrdinaryDiffEq.jl/issues/2977
65-
- group: OrdinaryDiffEqBDF
66-
version: 'pre'
6762
steps:
6863
- uses: actions/checkout@v6
6964
- uses: julia-actions/setup-julia@v2

0 commit comments

Comments
 (0)