Update FIRK interpolants #2970
Open
Update FIRK interpolants #2970
+277
−283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
reviewed
Jan 6, 2026
oscardssmith
reviewed
Jan 6, 2026
oscardssmith
reviewed
Jan 6, 2026
Co-authored-by: Oscar Smith <[email protected]>
Member
|
This is causing some convergence problems so it's not ready to merge yet. |
oscardssmith
reviewed
Jan 9, 2026
oscardssmith
reviewed
Jan 9, 2026
oscardssmith
reviewed
Jan 9, 2026
oscardssmith
reviewed
Jan 9, 2026
oscardssmith
approved these changes
Jan 9, 2026
Contributor
Author
|
oops wait tests are still failing apparently, too long solve lengths? |
Member
|
Tests still show something going very wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Modified FIRK Interpolants to use lagrange interpolants for better applicability in DiscoDiffEq (to come). Other benefits include faster run time and higher order interpolation.