Skip to content

Commit 2d48e6d

Browse files
Merge pull request #1452 from ChrisRackauckas-Claude/cc/remove-tracker-broken-guards-1331
Remove Tracker @test_broken guards (closes #1331)
2 parents 8ce15a5 + 1091ac7 commit 2d48e6d

2 files changed

Lines changed: 3 additions & 28 deletions

File tree

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ ChainRulesCore = "0.10.7, 1"
6767
ComponentArrays = "0.15.5"
6868
ConstructionBase = "1.5"
6969
DelayDiffEq = "5.43.2, 6"
70-
DiffEqBase = "7.4.0"
70+
DiffEqBase = "7.5.5"
7171
DiffEqCallbacks = "4.8"
7272
DiffEqNoiseProcess = "5.19"
7373
DifferentiationInterface = "0.7.17"

test/concrete_solve_derivatives.jl

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -514,11 +514,6 @@ Additional Tests: save_idxs, save_everystep, etc.
514514
ref_grad_idx = ForwardDiff.gradient(ref_loss_idx, u0p)
515515

516516
@testset "save_idxs - $backend_name" for (backend_name, grad_fn) in REVERSE_BACKENDS
517-
# Tracker has issues on Julia 1.12+ - see issue #1331
518-
if backend_name == "Tracker" && VERSION >= v"1.12"
519-
@test_broken false
520-
continue
521-
end
522517
loss = u0p -> sum(
523518
solve(
524519
prob, Tsit5(), u0 = u0p[1:2], p = u0p[3:end],
@@ -544,11 +539,6 @@ end
544539
ref_grad_end = ForwardDiff.gradient(ref_loss_end, u0p)
545540

546541
@testset "save_end only - $backend_name" for (backend_name, grad_fn) in REVERSE_BACKENDS
547-
# Tracker has issues on Julia 1.12+ - see issue #1331
548-
if backend_name == "Tracker" && VERSION >= v"1.12"
549-
@test_broken false
550-
continue
551-
end
552542
loss = u0p -> sum(
553543
solve(
554544
prob, Tsit5(), u0 = u0p[1:2], p = u0p[3:end],
@@ -575,11 +565,6 @@ end
575565
ref_grad_saveat = ForwardDiff.gradient(ref_loss_saveat, u0p)
576566

577567
@testset "saveat=2.3 - $backend_name" for (backend_name, grad_fn) in REVERSE_BACKENDS
578-
# Tracker has issues on Julia 1.12+ - see issue #1331
579-
if backend_name == "Tracker" && VERSION >= v"1.12"
580-
@test_broken false
581-
continue
582-
end
583568
loss = u0p -> sum(
584569
solve(
585570
proboop, Tsit5(), u0 = u0p[1:2], p = u0p[3:end],
@@ -607,11 +592,6 @@ end
607592
ref_grad_vec = ForwardDiff.gradient(ref_loss_vec, p)
608593

609594
@testset "VecOfArray - $backend_name" for (backend_name, grad_fn) in REVERSE_BACKENDS
610-
# Tracker has issues on Julia 1.12+ - see issue #1331
611-
if backend_name == "Tracker" && VERSION >= v"1.12"
612-
@test_broken false
613-
continue
614-
end
615595
result = grad_fn(ref_loss_vec, p)
616596
@test result ref_grad_vec
617597
end
@@ -732,13 +712,8 @@ https://github.com/SciML/SciMLSensitivity.jl/issues/943
732712
@test grad_fd grad_fi atol = 1.0e-2
733713

734714
@testset "BouncingBall - $backend_name" for (backend_name, grad_fn) in REVERSE_BACKENDS
735-
if backend_name == "Tracker" && VERSION >= v"1.12"
736-
# Tracker has issues on Julia 1.12+ - see issue #1331
737-
@test_broken false
738-
else
739-
result = grad_fn(loss_ball, p_ball)
740-
@test result grad_fd atol = 1.0e-4
741-
end
715+
result = grad_fn(loss_ball, p_ball)
716+
@test result grad_fd atol = 1.0e-4
742717
end
743718
end
744719

0 commit comments

Comments
 (0)