Skip to content

Commit 3842a66

Browse files
Assert the extension actually loaded in QA
`Base.get_extension` returning `nothing` makes ExplicitImports skip the extension silently, so a broken extension would leave QA green while dropping extension coverage back to zero. Check the module exists before `run_qa`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent 4c28558 commit 3842a66

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

test/qa/qa.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ using Test
66
# load every weakdep here to bring the extensions into the QA scan.
77
using PrettyTables
88

9+
# ExplicitImports silently skips an extension that fails to load, so assert the
10+
# extension modules actually exist rather than trusting a green run_qa.
11+
@testset "Extensions loaded" begin
12+
@test Base.get_extension(SymbolicIndexingInterface, :SymbolicIndexingInterfacePrettyTablesExt) !== nothing
13+
end
14+
915
# ExplicitImports per-check ignore-lists: each entry is a dependency name that is
1016
# genuinely required but is neither exported nor declared `public` by its owner
1117
# package, and has no public alternative to switch to.

0 commit comments

Comments
 (0)