QA: scan the PrettyTables extension with ExplicitImports (#173)

* Make QA scan the PrettyTables extension

ExplicitImports only adds an extension module to its checked set when
`Base.get_extension` returns it, which requires the trigger package to be
loaded. The QA environment loaded no weakdeps, so
`SymbolicIndexingInterfacePrettyTablesExt` was never scanned.

Add PrettyTables to `test/qa/Project.toml` and `using` it in `test/qa/qa.jl`.
The newly-scanned extension reported implicit imports of `PrettyTables` and
`pretty_table`, fixed at the source with an explicit `using ... :` list rather
than an ignore entry.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

* Assert the extension actually loaded in QA

`Base.get_extension` returning `nothing` makes ExplicitImports skip the
extension silently, so a broken extension would leave QA green while dropping
extension coverage back to zero. Check the module exists before `run_qa`.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

---------

Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>

Author: ChrisRackauckas-Claude

ext/SymbolicIndexingInterfacePrettyTablesExt/SymbolicIndexingInterfacePrettyTablesExt.jl

@@ -3,7 +3,7 @@ module SymbolicIndexingInterfacePrettyTablesExt
 using SymbolicIndexingInterface
 using SymbolicIndexingInterface: ParameterIndexingProxy, parameter_symbols, symbolic_type,
     ArraySymbolic, getp
-using PrettyTables
+using PrettyTables: PrettyTables, pretty_table
 
 # Override the fallback implementation with the PrettyTables version
 function SymbolicIndexingInterface.show_params(

test/qa/Project.toml

@@ -1,6 +1,7 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
+PrettyTables = "08abe8d2-0d0c-5749-adfa-8a2ac140af0d"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
@@ -9,6 +10,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 [compat]
 Aqua = "0.8"
 JET = "0.9, 0.10, 0.11"
+PrettyTables = "3"
 SafeTestsets = "0.0.1, 0.1"
 SciMLTesting = "2.1"
 Test = "1"

test/qa/qa.jl

@@ -2,6 +2,16 @@ using SymbolicIndexingInterface
 using SciMLTesting
 using Test
 
+# ExplicitImports only sees an extension module once its trigger package is loaded, so
+# load every weakdep here to bring the extensions into the QA scan.
+using PrettyTables
+
+# ExplicitImports silently skips an extension that fails to load, so assert the
+# extension modules actually exist rather than trusting a green run_qa.
+@testset "Extensions loaded" begin
+    @test Base.get_extension(SymbolicIndexingInterface, :SymbolicIndexingInterfacePrettyTablesExt) !== nothing
+end
+
 # ExplicitImports per-check ignore-lists: each entry is a dependency name that is
 # genuinely required but is neither exported nor declared `public` by its owner
 # package, and has no public alternative to switch to.