Skip to content

Commit f2b3266

Browse files
committed
Fix workspace builder and tests
1 parent 5bd6271 commit f2b3266

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

dataforge-context/src/commonTest/kotlin/space/kscience/dataforge/context/ContextSerializerTest.kt

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package space.kscience.dataforge.context
22

33
import kotlinx.serialization.KSerializer
4+
import kotlinx.serialization.PolymorphicSerializer
45
import kotlinx.serialization.Serializable
56
import kotlinx.serialization.descriptors.SerialDescriptor
67
import kotlinx.serialization.encoding.Decoder
78
import kotlinx.serialization.encoding.Encoder
89
import kotlinx.serialization.modules.SerializersModule
910
import kotlinx.serialization.modules.polymorphic
1011
import kotlinx.serialization.modules.subclass
11-
import kotlinx.serialization.serializer
1212
import kotlin.test.Test
1313
import kotlin.test.assertEquals
1414
import kotlin.test.assertFails
@@ -71,6 +71,8 @@ class ContextSerializerTest {
7171

7272
}
7373

74+
val polymorphicSerializer = PolymorphicSerializer(Body::class)
75+
7476

7577
@Test
7678
fun testContextWithSerializers() {
@@ -80,9 +82,9 @@ class ContextSerializerTest {
8082
}
8183

8284

83-
val string = context.json.encodeToString(serializer<Body>(), BodyA())
85+
val string = context.json.encodeToString(polymorphicSerializer, BodyA())
8486

85-
assertTrue { context.json.decodeFromString<Body>(string) is BodyA }
87+
assertTrue { context.json.decodeFromString(polymorphicSerializer, string) is BodyA }
8688

8789
}
8890

@@ -97,14 +99,14 @@ class ContextSerializerTest {
9799
plugin(PluginB())
98100
}
99101

100-
val stringA = childContext.json.encodeToString(serializer<Body>(), BodyA())
102+
val stringA = childContext.json.encodeToString(polymorphicSerializer, BodyA())
101103

102-
assertTrue { childContext.json.decodeFromString<Body>(stringA) is BodyA }
103-
val stringB = childContext.json.encodeToString(serializer<Body>(), BodyB())
104+
assertTrue { childContext.json.decodeFromString<Body>(polymorphicSerializer, stringA) is BodyA }
105+
val stringB = childContext.json.encodeToString(polymorphicSerializer, BodyB())
104106

105-
assertTrue { childContext.json.decodeFromString<Body>(stringB) is BodyB }
107+
assertTrue { childContext.json.decodeFromString<Body>(polymorphicSerializer, stringB) is BodyB }
106108

107-
assertEquals("\"Fail\"", parentContext.json.encodeToString(serializer<Body>(), BodyB()))
109+
assertEquals("\"Fail\"", parentContext.json.encodeToString(polymorphicSerializer, BodyB()))
108110

109111
}
110112

@@ -118,7 +120,7 @@ class ContextSerializerTest {
118120
}
119121

120122
assertFails {
121-
context.json.encodeToString(serializer<Body>(), BodyB())
123+
context.json.encodeToString(polymorphicSerializer, BodyB())
122124
}
123125
}
124126

dataforge-data/src/jvmTest/kotlin/space/kscience/dataforge/data/ActionsTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import space.kscience.dataforge.actions.mapping
88
import space.kscience.dataforge.misc.DFExperimental
99
import kotlin.test.Test
1010
import kotlin.test.assertEquals
11-
import kotlin.time.Duration.Companion.milliseconds
11+
import kotlin.time.Duration.Companion.seconds
1212

1313
@OptIn(DFExperimental::class, ExperimentalCoroutinesApi::class)
1414
internal class ActionsTest {
1515
@Test
16-
fun testStaticMapAction() = runTest(timeout = 500.milliseconds) {
16+
fun testStaticMapAction() = runTest(timeout = 1.seconds) {
1717
val plusOne = Action.mapping<Int, Int> {
1818
result { it + 1 }
1919
}
@@ -30,7 +30,7 @@ internal class ActionsTest {
3030
}
3131

3232
@Test
33-
fun testDynamicMapAction() = runTest(timeout = 500.milliseconds) {
33+
fun testDynamicMapAction() = runTest(timeout = 1.seconds) {
3434
val plusOne = Action.mapping<Int, Int> {
3535
result { it + 1 }
3636
}

dataforge-workspace/src/commonMain/kotlin/space/kscience/dataforge/workspace/WorkspaceBuilder.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import space.kscience.dataforge.meta.descriptors.MetaDescriptor
1111
import space.kscience.dataforge.meta.descriptors.MetaDescriptorBuilder
1212
import space.kscience.dataforge.misc.DFBuilder
1313
import space.kscience.dataforge.names.Name
14-
import space.kscience.dataforge.names.asName
1514
import kotlin.properties.PropertyDelegateProvider
1615
import kotlin.properties.ReadOnlyProperty
1716

@@ -114,8 +113,8 @@ public class WorkspaceBuilder(
114113
/**
115114
* Define a context for the workspace
116115
*/
117-
public fun context(block: ContextBuilder.() -> Unit = {}) {
118-
this.context = parentContext.buildContext("workspace".asName(), block)
116+
public fun context(contextName: Name? = null, block: ContextBuilder.() -> Unit = {}) {
117+
this.context = parentContext.buildContext(contextName, block)
119118
}
120119

121120
/**

0 commit comments

Comments
 (0)