Merge pull request #1067 from yileicn/master

hotfix agent instruction cache question

Author: Oceania2018

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.GetAgents.cs

@@ -70,6 +70,11 @@ public async Task<Agent> GetAgent(string id)
         }
 
         profile.Plugin = GetPlugin(profile.Id);
+
+        //add default instruction to ChannelInstructions
+        var defaultInstruction = new ChannelInstruction() { Channel = string.Empty, Instruction = profile?.Instruction };
+        profile.ChannelInstructions.Insert(0, defaultInstruction);
+
         return profile;
     }
 

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.LoadAgent.cs

@@ -71,14 +71,10 @@ private void OverrideInstructionByChannel(Agent agent)
 
         var state = _services.GetRequiredService<IConversationStateService>();
         var channel = state.GetState("channel");
-
-        if (string.IsNullOrWhiteSpace(channel))
-        {
-            return;
-        }
-
+        
         var found = instructions.FirstOrDefault(x => x.Channel.IsEqualTo(channel));
-        agent.Instruction = !string.IsNullOrWhiteSpace(found?.Instruction) ? found.Instruction : agent.Instruction;
+        var defaultInstruction = instructions.FirstOrDefault(x => x.Channel == string.Empty);
+        agent.Instruction = !string.IsNullOrWhiteSpace(found?.Instruction) ? found.Instruction : defaultInstruction?.Instruction;
     }
 
     private void PopulateState(Dictionary<string, object> dict)