frontend: password reset fixes from code review

Author: RMCrean

packages/divbase-api/src/divbase_api/frontend_routes/profile.py

@@ -111,6 +111,7 @@ def edit_profile_failed_response(error_message: str):
                 "request": request,
                 "current_user": current_user,
                 "swedish_universities": SWEDISH_UNIVERSITIES,
+                "known_job_roles": KNOWN_JOB_ROLES,
                 "name": name,
                 "organisation": organisation,
                 "organisation_other": organisation_other,

packages/divbase-api/src/divbase_api/static/js/password_validation.js

@@ -4,11 +4,14 @@ Validates the user password for both registration and password reset:
 1. Checks that the password and confirm password fields match.
 2. Checks that the password is not one of the 10,000 most common passwords. 
 3. Min password length specified in HTML inputs 
+
+Will prevent form submission if issues. 
 */
 
 const passwordInput = document.getElementById('password');
 const confirmPasswordInput = document.getElementById('confirm_password');
-const registerForm = document.getElementById('registerForm');
+const form = document.getElementById("registerForm") || document.getElementById("resetPasswordForm");
+
 let commonPasswords = new Set();
 
 function validatePasswords() {
@@ -35,10 +38,10 @@ async function setupPasswordValidation() {
         passwordInput.addEventListener('input', validatePasswords);
         confirmPasswordInput.addEventListener('input', validatePasswords);
 
-        registerForm.addEventListener('submit', (event) => {
+        form.addEventListener('submit', (event) => {
             validatePasswords();
-            if (!registerForm.checkValidity()) {
-                event.preventDefault(); // Stop registration form submission
+            if (!form.checkValidity()) {
+                event.preventDefault(); // Stop form submission
             }
         });
 

packages/divbase-api/src/divbase_api/templates/auth_pages/reset_password.html

@@ -13,7 +13,7 @@ <h4 class="mt-2">Reset Your Password</h4>
                         <p class="text-muted">Enter your new password for {{ email }}</p>
                     </div>
 
-                    <form method="post" action="/reset-password">
+                    <form method="post" action="/reset-password" id="resetPasswordForm">
                         <input type="hidden" name="token" value="{{ token }}">
                         <input type="hidden" name="email" value="{{ email }}">