Skip to content

Commit effffbe

Browse files
committed
Add linter isort to project and reformat imports.
1 parent 15a1bd6 commit effffbe

9 files changed

Lines changed: 33 additions & 11 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,16 @@ jobs:
2727
- name: Checkout code
2828
uses: actions/checkout@v4
2929

30+
- name: Set up Python
31+
uses: actions/setup-python@v5
32+
with:
33+
python-version: "3.12"
34+
35+
- name: Run isort # pip-based (flexible)
36+
run: |
37+
pip install isort
38+
isort . --check --diff --profile black
39+
3040
- name: Run linter black
3141
uses: psf/black@stable
3242
with:

serve_event_listener/event_listener.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@
66

77
import requests
88
import urllib3
9-
from urllib3.exceptions import HTTPError
109
from kubernetes import client, config, watch
1110
from kubernetes.client.exceptions import ApiException
12-
from serve_event_listener.http_client import get as http_get, make_session
11+
from urllib3.exceptions import HTTPError
12+
13+
from serve_event_listener.http_client import get as http_get
14+
from serve_event_listener.http_client import make_session
1315
from serve_event_listener.http_client import post as http_post
1416
from serve_event_listener.status_data import StatusData
1517
from serve_event_listener.status_queue import StatusQueue
1618

17-
1819
logger = logging.getLogger(__name__)
1920

2021
# Disable urllib3 and Kubernetes client debug logs

serve_event_listener/http_client/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
import logging
44
import time
5-
from typing import Optional, Mapping, Any, Tuple, Callable
5+
from typing import Any, Callable, Mapping, Optional, Tuple
6+
67
import requests
78

89
logger = logging.getLogger(__name__)

serve_event_listener/http_client/session.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"""Configure requests.Session with retries, adapters, and TLS settings."""
22

33
from typing import Mapping, Optional, Tuple
4+
45
import requests
56
from requests.adapters import HTTPAdapter
67
from urllib3.util.retry import Retry

serve_event_listener/main.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import argparse
22
import logging
33
import os
4+
45
from colorlog import ColoredFormatter
6+
57
from serve_event_listener.event_listener import EventListener
68

79
# Configure the logger

serve_event_listener/status_queue.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import logging
22
import queue
3-
import requests
43
import threading
54
import time
65
from datetime import datetime, timezone
6+
7+
import requests
8+
79
from serve_event_listener.http_client import post as http_post
810

911
logger = logging.getLogger(__name__)
@@ -28,7 +30,8 @@ def __init__(
2830
def add(self, status_data) -> None:
2931
"""Adds a status_data object to the queue."""
3032
logger.debug(
31-
"K8s release status data added to queue. Queue now has length %s", self.queue.qsize() + 1
33+
"K8s release status data added to queue. Queue now has length %s",
34+
self.queue.qsize() + 1,
3235
)
3336
self.queue.put(status_data)
3437

tests/http_client/test_http_helpers.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import unittest
22
from unittest.mock import MagicMock
3-
from urllib3.util.retry import Retry
3+
44
import requests
55
from requests.adapters import HTTPAdapter
6-
from serve_event_listener.http_client import make_session, _request
6+
from urllib3.util.retry import Retry
7+
8+
from serve_event_listener.http_client import _request, make_session
79

810

911
class TestMakeSession(unittest.TestCase):

tests/test_event_listener.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import logging
22
import unittest
3-
from unittest.mock import patch, MagicMock
43
from types import SimpleNamespace
4+
from unittest.mock import MagicMock, patch
5+
56
import requests
67

78
from serve_event_listener.event_listener import EventListener

tests/test_status_queue.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
import unittest
21
import threading
32
import time
4-
from unittest.mock import patch, MagicMock
3+
import unittest
54
from types import SimpleNamespace
5+
from unittest.mock import MagicMock, patch
66

77
import requests
8+
89
from serve_event_listener.status_queue import StatusQueue
910

1011

0 commit comments

Comments
 (0)