Application window is not displayed after upgrade (snap)

[mmmarcos]

Parsec version

3.6.0-rc.1

Which platform(s) you have observed the problem

• Any
• macOS
• Linux
• Windows
• Web

Bug description

After snap refresh to update Parsec, the app starts but the window is not displayed, only the tray icon is visible but both options (Show Parsec, Quit) seem to do nothing, the app window does not appear.

Reproduction steps

1. `snap refresh parsec` (make sure to be in the right channel to track release candidate)
2. `snap run parsec`

Relevant output:

No response

[mmmarcos]

After some digging, it seems that electron-window-state (used to save window position between app runs) does no longer position the app window and, on app upgrade, the file window-state.json created by the previous version makes the app window to disappear. It also has issues when display setup changes (external display, zoom ratio, etc.).

File window-state.json before app upgrade:

{"width":1368,"height":844,"x":0,"y":0,
"displayBounds"{"x":0,"y":0,"width":1920,"height":1200},
"isMaximized":false,"isFullScreen":false}

After upgrade, the main window is not displayed when launching Parsec.

If I remove the file, a new one is recreated with the same content (although keys are in different places):

{"width":1368,"height":844,"x":0,"y":0,
"isMaximized":false,"isFullScreen":false,
"displayBounds":{"x":0,"y":0,"width":1920,"height":1200}}

If I put back the previous file, app window is again not displayed o.O

[mmmarcos]

Some alternatives:

1. Try to fix it, seems that calling setBounds worked in some cases see comment below
2. Removing window-state.json on app upgrade (should be feasible on snap) would not fix the issue in case of changes to display configuration.
3. Removing or replacing electron-window-state dependency.

Considering that electron-window-state has not been updated in 7 years, removing the dependency seems the right choice since this feature is not a specific requirement.

[mmmarcos]

Another reason for 3: since Electron v38 wayland is used by default and it seems that it is not possible to do this in Electron anymore:

It is not possible for regular windows to position themselves programmatically on Wayland, and that includes choosing what display to open the window on. There's nothing Electron can do here unless future Wayland extensions make this possible.

electron/electron#48749 (comment)