Request: Make classes StyleContext and LexAccessor "header-only classes"

[kcrif]

Background:
Starting with Scintilla 3.2.3, we have developed our own lexers for various robot programming languages.

To update to the current Scintilla version using vcpkg, we need the StyleContext and LexAccessor classes from the Lexilla project. Unfortunately, this results in an error ("Unresolved external") because part of the implementation is now located in the CXX files.

Therefore, we have to manually add these files to our solution, which makes using vcpkg cumbersome.

Please convert these classes into header-only classes and move the files (Accessor.h, CharacterSet.h, LexAccessor.h, LexerModule.h, StyleContext.h) to the include folder.

[nyamatongwe]

Therefore, we have to manually add these files to our solution, which makes using vcpkg cumbersome.

This is not a strong argument. There are various other techniques you could use such as referencing or copying the implementation files.

Header bloat leads to poorer modularity so this feature is rejected.

[kcrif]

Header bloat leads to poorer modularity

Yes, but no.

Currently, we ONLY need the StyleContext::StyleContext class and perhaps the StyleContext::MatchIgnoreCase function. That's only about 30 lines of code.

Since we're using vcpkg, we don't really want to bother with the source code of the DLLs we use. Now we have to copy the code from a dynamic vcpkg directory (C:\ProgramData\vcpkg\buildtrees\lexilla\src\5.4.5-dc83354716.clean\lexlib) and then adjust the code, including includes, just because we're using the StyleContext::StyleContext class in our lexer. And every time there's a new version, we may have to adjust the code again.

Of course, we could do it that way, but it's tedious.

If at least the constructor StyleContext::StyleContext (25 lines) were in the header, that would be enough for us.