[Bug]: Pop-up error when installing autohotkey v2.0.10

[29039]

Prerequisites

• I have written a descriptive issue title.
• I have searched all issues/PRs to ensure it has not already been reported or fixed.
• I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

autohotkey

Expected/Current Behaviour

Install as a portable app in \scoop\apps\autohotkey without error

Steps to Reproduce

PS C:\> scoop bucket add extras
Checking repo... OK
The extras bucket was added successfully.
PS C:\> scoop install autohotkey
Installing 'autohotkey' (2.0.10) [64bit] from extras bucket
AutoHotkey_2.0.10.zip (2.9 MB) [==============================================================================] 100%
Checking hash of AutoHotkey_2.0.10.zip ... ok.
Extracting AutoHotkey_2.0.10.zip ... done.
Running installer script...

Then a pop-up:
---------------------------
AutoHotkey
---------------------------
It looks like you've used an unsupported method to set the default program for .ahk files. This will prevent the standard context menu and launcher (version auto-detect) functionality from working. Would you like this setting to be reset for you?
---------------------------
Yes   No   
---------------------------

The console is locked until user input for the popup

I have to run scoop as Administrator for reasons - not sure if it is related.

Possible Solution

Every other scoop app I have ever installed are basically portable apps without any registry etc. added, so I am confused why this package is different. Why not just take out the post install script, etc. completely and just have it living as a portable app, shim'd if need be

Scoop and Buckets Version

PS C:\> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
674a0a86a (HEAD -> master, origin/master, origin/HEAD) dolphin: Update to version 23.08.4-2113

Scoop Config

PS C:\> scoop config

last_update
-----------
2023-12-09T12:32:58.8654972+11:00

PowerShell Version

PS C:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.3031
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.3031
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

[HUMORCE]

Cannot find a way to reproduce this issue, can you provides a minimal reproduction?

---

Every other scoop app I have ever installed are basically portable apps without any registry etc. added, so I am confused why this package is different. Why not just take out the post install script, etc. completely and just have it living as a portable app, shim'd if need be

Please see commit history, If you have a better method to improve its installation, feel free to make a PR.

[29039]

I am looking a bit deeper into this, and I think that it might be half AHK bug and half Scoop flaw.

From the Scoop side -

Runs an installer. As per the manifest:

"installer": {
        "script": [
            "$ahk = @('/script', \"`\"$dir\\installer\\UX\\install.ahk`\"\", '/to', \"`\"$dir`\"\", '/user', '/silent')",
            "if ($global) { $ahk = @('/script', \"`\"$dir\\installer\\UX\\install.ahk`\"\", '/to', \"`\"$dir`\"\", '/silent') }",
            "Start-Process \"$dir\\installer\\AutoHotkey32.exe\" -ArgumentList $ahk -Wait"
        ]
    }

I can see that Scoop is putting forward a 'silent' argument, and trusting that the program will actually respect that. But if it doesn't, then the script/automation gets stuck.

I would suggest avoiding install scripts, because:

1. It's risky - What if the script does not complete due to bug or other unforeseen circumstances as can be seen here. There is no error handling in case an install script does not complete, and/or even to run in an outside process.
2. Scoop does not have a switch to say '--skip-install' - I have no way to choose not to run it if using Scoop.
3. It's uncommon, can be done manually and goes against being 'portable' - This is the only thing in Scoop with an installer I have come across so far (I use main and extras buckets). Usually I get a message like:

Notes
-----
Add 7-Zip as a context menu option by running:
"C:\Users\WDAGUtilityAccount\scoop\apps\7zip\current\install-context.reg"

or

Notes
-----
Set Git Credential Manager Core by running: "git config --global credential.helper manager"

To add context menu entries, run 'C:\Users\WDAGUtilityAccount\scoop\apps\git\current\install-context.reg'

To create file-associations for .git* and .sh files, run
'C:\Users\WDAGUtilityAccount\scoop\apps\git\current\install-file-associations.reg'

and I like this method of settings myself or add that into the script, because often I want a portable app without associations set up.

From the AHK side -

The install.ahk runs (if it exists) reset-assoc.ahk

keyname := "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ahk\UserChoice"
initial_progid := RegRead(keyname, "ProgId", "")
legacy_key := "HKCU\Software\Classes\.ahk"
legacy_assoc := RegRead(legacy_key,, "AutoHotkeyScript")
if A_Args.Length && A_Args[1] = '/check' {
    if (initial_progid = "" || initial_progid = "AutoHotkeyScript") && legacy_assoc = "AutoHotkeyScript"
        || MsgBox("It looks like you've used an unsupported method to set the default program for .ahk files. "
            . "This will prevent the standard context menu and launcher (version auto-detect) functionality "
            . "from working. Would you like this setting to be reset for you?", "AutoHotkey", "Icon! y/n") != "yes"
        ExitApp
}

Problems:

1. It ignores /silent
2. It should just make a choice for the user instead of bothering them with this, especially if there is /silent
3. It can be caused by opening an unassociated .ahk file with notepad and have "Always use this app to open .ahk files" ticked to make it have an auto association, before installing autohotkey.

I will pass this to the AHK devs. But it highlights that install scripts are a risky proposition and why I don't want to use them.

[29039]

If you have a better method to improve its installation, feel free to make a PR.

I have been investigating this.

Ideally, I'd move "installer:" task to the "notes:" section but I can't figure out a simple one-liner which isn't too long which would go ahead and install it manually.

Is it considered acceptable (to scoop standards) to make a .bat script then basically tell the user to run that .bat file, which exists as an extra file from the official package itself? (Assuming the .bat itself is of high quality)

I note that in 7-zip it adds in "install-context.reg" and "uninstall-context.reg" files under https://github.com/ScoopInstaller/Main/tree/master/scripts/7-zip to basically do this (with a reg file not a bat file) so there is precedent for such a thing.

I am just a bit unfamiliar with Scoop's code standards.