Skip to content

yaak@2026.4.0: Fix shortcuts#17859

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
Supremesir:fix-yaak-shortcut
May 22, 2026
Merged

yaak@2026.4.0: Fix shortcuts#17859
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
Supremesir:fix-yaak-shortcut

Conversation

@Supremesir

Copy link
Copy Markdown
Contributor

Description

Fix the shortcuts field in yaak.json to use the correct executable name.

The upstream project renamed the main executable from yaak-app.exe to yaak-app-client.exe in recent releases. This caused shortcut creation to fail during scoop install yaak:

Creating shortcut for Yaak (yaak-app.exe) failed: Couldn't find C:\Users\Fang\scoop\apps\yaak\current\yaak-app.exe

Motivation and Context

Fixes the broken shortcut creation when installing yaak via Scoop. The app installs and runs correctly, but the Start Menu shortcut is not created due to the exe name mismatch.

How Has This Been Tested?

Verified the actual executable name in the installed yaak directory:

C:\Users\Fang\scoop\apps\yaak\current\yaak-app-client.exe

The only .exe files in the install directory are:

  • yaak-app-client.exe (main app)
  • vendored/node/yaaknode.exe
  • vendored/protoc/yaakprotoc.exe

Checklist

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the master branch.
  • I have verified the manifest works by installing and checking the shortcut is created correctly.

The executable was renamed from `yaak-app.exe` to `yaak-app-client.exe`
in recent versions, causing shortcut creation to fail during installation.
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request updates the bucket/yaak.json manifest file used by Scoop, a Windows package manager. The change modifies the shortcuts array to reference yaak-app-client.exe instead of yaak-app.exe, correcting the executable name that will be created as a Windows shortcut when the Yaak application is installed via Scoop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ScoopInstaller/Extras#17064: Corrects a similar executable name mismatch in another Windows bucket manifest by updating the shortcuts array.
  • ScoopInstaller/Extras#16437: Initially added the bucket/yaak.json manifest with the original yaak-app.exe shortcut entry that this PR now corrects.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description fully addresses the template requirements with a clear explanation of the fix, motivation, testing verification, and all checklist items completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the yaak package version to 2026.4.0 and fixing the shortcut executable reference from yaak-app.exe to yaak-app-client.exe.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/yaak.json (1)

1-29: Local manifest verification steps before merge

Please run the standard Scoop checks locally for yaak:

scoop config debug true
scoop config gh_token <your-github-token>  # read-only token, optional for GitHub API

.\bin\checkver.ps1 -App yaak -f
.\bin\formatjson.ps1 -App yaak
scoop install bucket/yaak.json -a 64bit

Also keep the contribution references handy:

As per coding guidelines, manifest reviews should include clear local test guidance and links to the official contribution docs.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/yaak.json` around lines 1 - 29, Add a brief "Local verification"
section to the PR/manifest review notes describing the exact Scoop local test
commands and contribution links: instruct reviewers to run scoop config debug
true, optionally set scoop gh_token, then run .\bin\checkver.ps1 -App yaak -f,
.\bin\formatjson.ps1 -App yaak and scoop install bucket/yaak.json -a 64bit; also
include the two contribution reference links (Scoop CONTRIBUTING.md and Scoop
App-Manifests wiki) and mention validating keys in the yaak.json manifest such
as "checkver", "autoupdate", and "post_install" are correct before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/yaak.json`:
- Around line 1-29: Add a brief "Local verification" section to the PR/manifest
review notes describing the exact Scoop local test commands and contribution
links: instruct reviewers to run scoop config debug true, optionally set scoop
gh_token, then run .\bin\checkver.ps1 -App yaak -f, .\bin\formatjson.ps1 -App
yaak and scoop install bucket/yaak.json -a 64bit; also include the two
contribution reference links (Scoop CONTRIBUTING.md and Scoop App-Manifests
wiki) and mention validating keys in the yaak.json manifest such as "checkver",
"autoupdate", and "post_install" are correct before merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 06259009-e739-41fe-8e1e-cdc03cbe91cf

📥 Commits

Reviewing files that changed from the base of the PR and between 9f883c1 and 1d3ce3f.

📒 Files selected for processing (1)
  • bucket/yaak.json

@Supremesir

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

yaak

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title yaak@2026.4.0: Fix shortcut executable name yaak@2026.4.0: Fix shortcuts May 22, 2026

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng
z-Fng merged commit f6deff9 into ScoopInstaller:master May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants