yaak@2026.4.0: Fix shortcuts#17859
Conversation
The executable was renamed from `yaak-app.exe` to `yaak-app-client.exe` in recent versions, causing shortcut creation to fail during installation.
📝 WalkthroughWalkthroughThis pull request updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/yaak.json (1)
1-29: Local manifest verification steps before mergePlease run the standard Scoop checks locally for
yaak:scoop config debug true scoop config gh_token <your-github-token> # read-only token, optional for GitHub API .\bin\checkver.ps1 -App yaak -f .\bin\formatjson.ps1 -App yaak scoop install bucket/yaak.json -a 64bitAlso keep the contribution references handy:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, manifest reviews should include clear local test guidance and links to the official contribution docs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/yaak.json` around lines 1 - 29, Add a brief "Local verification" section to the PR/manifest review notes describing the exact Scoop local test commands and contribution links: instruct reviewers to run scoop config debug true, optionally set scoop gh_token, then run .\bin\checkver.ps1 -App yaak -f, .\bin\formatjson.ps1 -App yaak and scoop install bucket/yaak.json -a 64bit; also include the two contribution reference links (Scoop CONTRIBUTING.md and Scoop App-Manifests wiki) and mention validating keys in the yaak.json manifest such as "checkver", "autoupdate", and "post_install" are correct before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/yaak.json`:
- Around line 1-29: Add a brief "Local verification" section to the PR/manifest
review notes describing the exact Scoop local test commands and contribution
links: instruct reviewers to run scoop config debug true, optionally set scoop
gh_token, then run .\bin\checkver.ps1 -App yaak -f, .\bin\formatjson.ps1 -App
yaak and scoop install bucket/yaak.json -a 64bit; also include the two
contribution reference links (Scoop CONTRIBUTING.md and Scoop App-Manifests
wiki) and mention validating keys in the yaak.json manifest such as "checkver",
"autoupdate", and "post_install" are correct before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06259009-e739-41fe-8e1e-cdc03cbe91cf
📒 Files selected for processing (1)
bucket/yaak.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. yaak
|
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Description
Fix the
shortcutsfield inyaak.jsonto use the correct executable name.The upstream project renamed the main executable from
yaak-app.exetoyaak-app-client.exein recent releases. This caused shortcut creation to fail duringscoop install yaak:Motivation and Context
Fixes the broken shortcut creation when installing yaak via Scoop. The app installs and runs correctly, but the Start Menu shortcut is not created due to the exe name mismatch.
How Has This Been Tested?
Verified the actual executable name in the installed yaak directory:
The only
.exefiles in the install directory are:yaak-app-client.exe(main app)vendored/node/yaaknode.exevendored/protoc/yaakprotoc.exeChecklist
masterbranch.