Skip to content

stirlingpdf@2.11.0: Update suggest#17876

Merged
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
scillidan:stirling-pdf@2.11.0
May 30, 2026
Merged

stirlingpdf@2.11.0: Update suggest#17876
z-Fng merged 4 commits into
ScoopInstaller:masterfrom
scillidan:stirling-pdf@2.11.0

Conversation

@scillidan

@scillidan scillidan commented May 25, 2026

Copy link
Copy Markdown
Contributor

Refered https://docs.stirlingpdf.com/Installation/Windows%20Installation/#server-installation-steps.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the Stirling-PDF bucket manifest from version 2.3.1 to 2.11.0. The change updates the version field in the manifest header, replaces the 64-bit JAR download URL and its corresponding hash to match the v2.11.0 release artifact, and adjusts the Windows pre_install script to reflect the new release's jar entry point. The manifest structure, suggested dependencies, persistence configuration, and autoupdate template remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #17875 requires adding a stirling-pdf.bat file to launch with a visible console window using java instead of javaw, but the raw summary only documents version updates and jar hash changes without mentioning the bat file addition. Verify that the stirling-pdf.bat file was added to the manifest with proper java invocation (not javaw) to display the console window, matching the requirement from issue #17875.
Description check ⚠️ Warning The PR description is incomplete. It lacks a proper closing reference (Closes/Relates #XXXX) and a clear summary of changes beyond the checkbox confirmations. Add 'Closes #17875' or 'Relates to #17875' and provide a detailed summary of the changes made, including the version update and new bat file addition.
✅ Passed checks (3 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed Version bump to 2.11.0 and related manifest updates are directly tied to the bat file addition objective, but changes appear within scope of the stated PR goals.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title 'stirlingpdf@2.11.0: Update suggest' is only partially related to the main changeset, which primarily updates the version from 2.3.1 to 2.11.0, the download URL, hash, and pre_install script. While updating the suggest field is mentioned in the objectives, the title does not emphasize the primary version bump or other significant changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/stirling-pdf.json (1)

1-46: Testing instructions for the manifest.

Before merging, please test the manifest locally using these commands:

# Optional: Enable debug mode and set GitHub token (read access only, for GitHub API releases)
scoop config debug true
scoop config gh_token <your-github-token>

# Force version detection and autoupdate
.\bin\checkver.ps1 -App stirling-pdf -f

# Auto-format (Lint) the JSON manifest
.\bin\formatjson.ps1 -App stirling-pdf

# Test installation
scoop install bucket/stirling-pdf.json -a 64bit

# Launch the application to verify the batch file works correctly
stirling-pdf

# Uninstall after testing
scoop uninstall stirling-pdf

As per coding guidelines: Contribution Guide

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/stirling-pdf.json` around lines 1 - 46, Run the local manifest tests
exactly as described: enable debug and set gh_token (optional) with "scoop
config debug true" and "scoop config gh_token <token>", then force version
detection with the checkver helper (.\bin\checkver.ps1 -App stirling-pdf -f),
auto-format the JSON (.\bin\formatjson.ps1 -App stirling-pdf), install the
64-bit manifest (scoop install bucket/stirling-pdf.json -a 64bit), launch the
app to verify the pre_install batch wrapper (invoke "stirling-pdf") and finally
uninstall (scoop uninstall stirling-pdf); if any step fails, fix the manifest
keys referenced here (version, autoupdate, pre_install, shortcuts, persist,
architecture URL/hash) and re-run the steps until all checks pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/stirling-pdf.json`:
- Line 24: The pre_install value that writes stirling-pdf.bat is producing
incorrect batch escaping because PowerShell single-quoted string is emitting
backslashes before quotes (resulting in \" in the file); update the
"pre_install" command so it writes the literal batch line `@start` java.exe -jar
"%~dp0\Stirling-PDF.jar" %* into stirling-pdf.bat (i.e., ensure the file content
uses plain quotes around %~dp0\Stirling-PDF.jar and a single backslash before
Stirling-PDF.jar), by changing the string passed to Set-Content for the file
referenced as "$dir\\stirling-pdf.bat" so it emits the correct batch syntax.

---

Nitpick comments:
In `@bucket/stirling-pdf.json`:
- Around line 1-46: Run the local manifest tests exactly as described: enable
debug and set gh_token (optional) with "scoop config debug true" and "scoop
config gh_token <token>", then force version detection with the checkver helper
(.\bin\checkver.ps1 -App stirling-pdf -f), auto-format the JSON
(.\bin\formatjson.ps1 -App stirling-pdf), install the 64-bit manifest (scoop
install bucket/stirling-pdf.json -a 64bit), launch the app to verify the
pre_install batch wrapper (invoke "stirling-pdf") and finally uninstall (scoop
uninstall stirling-pdf); if any step fails, fix the manifest keys referenced
here (version, autoupdate, pre_install, shortcuts, persist, architecture
URL/hash) and re-run the steps until all checks pass.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0b0e470-fd5d-46db-bc7f-dd2e7adfcf2e

📥 Commits

Reviewing files that changed from the base of the PR and between 331a59e and f6417a8.

📒 Files selected for processing (1)
  • bucket/stirling-pdf.json

Comment thread bucket/stirling-pdf.json Outdated
@scillidan

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@z-Fng z-Fng changed the title stirlingpdf@2.11.0: Add a stirling-pdf.bat; Update suggest; Update version stirlingpdf@2.11.0: Add a stirling-pdf.bat; Update suggest May 25, 2026
@z-Fng

z-Fng commented May 25, 2026

Copy link
Copy Markdown
Contributor

Merge branch 'master' into stirling-pdf@2.11.0

Please base your PR on the latest master branch.

Comment thread bucket/stirling-pdf.json
Comment thread bucket/stirling-pdf.json Outdated
Removed pre_install script and shortcuts for Stirling PDF.
@scillidan

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@z-Fng z-Fng changed the title stirlingpdf@2.11.0: Add a stirling-pdf.bat; Update suggest stirlingpdf@2.11.0: Update suggest May 30, 2026
@z-Fng

z-Fng commented May 30, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

stirling-pdf

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@z-Fng
z-Fng merged commit 2dcbc84 into ScoopInstaller:master May 30, 2026
3 checks passed
@scillidan

Copy link
Copy Markdown
Contributor Author

Thanks for your review!

@scillidan
scillidan deleted the stirling-pdf@2.11.0 branch May 31, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants