stirlingpdf@2.11.0: Update suggest#17876
Conversation
📝 WalkthroughWalkthroughThis PR updates the Stirling-PDF bucket manifest from version 2.3.1 to 2.11.0. The change updates the version field in the manifest header, replaces the 64-bit JAR download URL and its corresponding hash to match the v2.11.0 release artifact, and adjusts the Windows Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/stirling-pdf.json (1)
1-46: Testing instructions for the manifest.Before merging, please test the manifest locally using these commands:
# Optional: Enable debug mode and set GitHub token (read access only, for GitHub API releases) scoop config debug true scoop config gh_token <your-github-token> # Force version detection and autoupdate .\bin\checkver.ps1 -App stirling-pdf -f # Auto-format (Lint) the JSON manifest .\bin\formatjson.ps1 -App stirling-pdf # Test installation scoop install bucket/stirling-pdf.json -a 64bit # Launch the application to verify the batch file works correctly stirling-pdf # Uninstall after testing scoop uninstall stirling-pdfAs per coding guidelines: Contribution Guide
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/stirling-pdf.json` around lines 1 - 46, Run the local manifest tests exactly as described: enable debug and set gh_token (optional) with "scoop config debug true" and "scoop config gh_token <token>", then force version detection with the checkver helper (.\bin\checkver.ps1 -App stirling-pdf -f), auto-format the JSON (.\bin\formatjson.ps1 -App stirling-pdf), install the 64-bit manifest (scoop install bucket/stirling-pdf.json -a 64bit), launch the app to verify the pre_install batch wrapper (invoke "stirling-pdf") and finally uninstall (scoop uninstall stirling-pdf); if any step fails, fix the manifest keys referenced here (version, autoupdate, pre_install, shortcuts, persist, architecture URL/hash) and re-run the steps until all checks pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/stirling-pdf.json`:
- Line 24: The pre_install value that writes stirling-pdf.bat is producing
incorrect batch escaping because PowerShell single-quoted string is emitting
backslashes before quotes (resulting in \" in the file); update the
"pre_install" command so it writes the literal batch line `@start` java.exe -jar
"%~dp0\Stirling-PDF.jar" %* into stirling-pdf.bat (i.e., ensure the file content
uses plain quotes around %~dp0\Stirling-PDF.jar and a single backslash before
Stirling-PDF.jar), by changing the string passed to Set-Content for the file
referenced as "$dir\\stirling-pdf.bat" so it emits the correct batch syntax.
---
Nitpick comments:
In `@bucket/stirling-pdf.json`:
- Around line 1-46: Run the local manifest tests exactly as described: enable
debug and set gh_token (optional) with "scoop config debug true" and "scoop
config gh_token <token>", then force version detection with the checkver helper
(.\bin\checkver.ps1 -App stirling-pdf -f), auto-format the JSON
(.\bin\formatjson.ps1 -App stirling-pdf), install the 64-bit manifest (scoop
install bucket/stirling-pdf.json -a 64bit), launch the app to verify the
pre_install batch wrapper (invoke "stirling-pdf") and finally uninstall (scoop
uninstall stirling-pdf); if any step fails, fix the manifest keys referenced
here (version, autoupdate, pre_install, shortcuts, persist, architecture
URL/hash) and re-run the steps until all checks pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d0b0e470-fd5d-46db-bc7f-dd2e7adfcf2e
📒 Files selected for processing (1)
bucket/stirling-pdf.json
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Please base your PR on the latest master branch. |
Removed pre_install script and shortcuts for Stirling PDF.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
suggest
|
/verify |
|
All changes look good. Wait for review from human collaborators. stirling-pdf
|
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
|
Thanks for your review! |
Refered https://docs.stirlingpdf.com/Installation/Windows%20Installation/#server-installation-steps.
<manifest-name[@version]|chore>: <general summary of the pull request>