Skip to content

ungoogled-chromium: Update to version 148.0.7778.178-1.1, fix checkver, simplify autoupdate#17879

Merged
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
o-l-a-v:patch-41
May 27, 2026
Merged

ungoogled-chromium: Update to version 148.0.7778.178-1.1, fix checkver, simplify autoupdate#17879
z-Fng merged 2 commits into
ScoopInstaller:masterfrom
o-l-a-v:patch-41

Conversation

@o-l-a-v

@o-l-a-v o-l-a-v commented May 25, 2026

Copy link
Copy Markdown
Contributor

Closes #17874

  • Updated to 148.0.7778.167-1.1
  • Simplified checkver: Use GitHub API + JSON path to exclude prerelease and only return tag_name
  • Simplified autoupdate: Hash is added to GitHub releases artifacts, and Scoop handles that by default
  • Reorder some manifest properties to align with authoring guidelines
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5df5e9f9-c2f5-432e-a7bd-7c273d2b30da

📥 Commits

Reviewing files that changed from the base of the PR and between c193f28 and 28169b6.

📒 Files selected for processing (1)
  • bucket/ungoogled-chromium.json

📝 Walkthrough

Walkthrough

This PR updates the ungoogled-chromium Scoop manifest: the package version is bumped to 148.0.7778.178-1.1 and per-architecture download url, hash, and extract_dir entries for 64bit, 32bit, and arm64 are updated. The checkver entry was changed to a GitHub Releases configuration (removing the explicit tag regex) and each autoupdate architecture entry was simplified to include only url and extract_dir templates using $version, removing per-architecture hash scraping.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating ungoogled-chromium to version 148.0.7778.178-1.1 and fixing checkver/simplifying autoupdate.
Description check ✅ Passed The description includes the issue reference (#17874), addresses the primary changes, and confirms the conventional PR title format and contributing guide review, though version number differs between title and description.
Linked Issues check ✅ Passed The PR successfully addresses the core requirement of issue #17874 by updating the manifest version and fixing checkver/autoupdate configurations to enable automatic detection of latest releases.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue objective: updating ungoogled-chromium manifest, fixing checkver, and simplifying autoupdate configuration as needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/ungoogled-chromium.json (1)

41-60: Please run the standard manifest checks locally before merge.

Scoop’s contribution guide asks bucket contributors to test the manifest and confirm autoupdate, and the autoupdate wiki specifically recommends validating the generated url, hash, and extract_dir with checkver.ps1. (github.com)

Suggested commands
scoop config debug true
scoop config gh_token <your-github-token>
.\bin\checkver.ps1 -App ungoogled-chromium -f
.\bin\formatjson.ps1 -App ungoogled-chromium
scoop install bucket/ungoogled-chromium.json -a 64bit
scoop install bucket/ungoogled-chromium.json -a 32bit
scoop install bucket/ungoogled-chromium.json -a arm64

As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/ungoogled-chromium.json` around lines 41 - 60, Run the standard local
manifest checks and update the PR with validation results: execute
.\bin\checkver.ps1 -App ungoogled-chromium -f to validate the checkver output,
then .\bin\formatjson.ps1 -App ungoogled-chromium to update the manifest;
confirm the autoupdate block’s generated url, hash and extract_dir values for
each architecture (64bit/32bit/arm64) are correct and that the URLs in the
autoupdate "url" fields actually download the expected zip, and include the
successful install test results (scoop install bucket/ungoogled-chromium.json -a
64bit/32bit/arm64) in the PR description so maintainers can see the manifest
passed local validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/ungoogled-chromium.json`:
- Around line 42-43: The checkver.jsonpath currently ("$[?(@.prerelease ==
false)].tag_name") can match multiple releases; update the manifest's checkver
to deterministically pick a single tag by narrowing the JSONPath to select a
single element (e.g. index the filtered array like "$[?(@.prerelease ==
false)][0].tag_name") or alternatively add a "reverse": true or a "regex" to the
checkver block so the selected tag is explicit and reproducible; modify the
checkver entry in bucket/ungoogled-chromium.json accordingly.

---

Nitpick comments:
In `@bucket/ungoogled-chromium.json`:
- Around line 41-60: Run the standard local manifest checks and update the PR
with validation results: execute .\bin\checkver.ps1 -App ungoogled-chromium -f
to validate the checkver output, then .\bin\formatjson.ps1 -App
ungoogled-chromium to update the manifest; confirm the autoupdate block’s
generated url, hash and extract_dir values for each architecture
(64bit/32bit/arm64) are correct and that the URLs in the autoupdate "url" fields
actually download the expected zip, and include the successful install test
results (scoop install bucket/ungoogled-chromium.json -a 64bit/32bit/arm64) in
the PR description so maintainers can see the manifest passed local validation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 90ee6abf-124e-4a0a-a96d-739bbc89f2c3

📥 Commits

Reviewing files that changed from the base of the PR and between 14d7ef7 and c193f28.

📒 Files selected for processing (1)
  • bucket/ungoogled-chromium.json

Comment thread bucket/ungoogled-chromium.json Outdated
Comment thread bucket/ungoogled-chromium.json Outdated
@z-Fng z-Fng changed the title ungoogled-chromium: Updated to 148.0.7778.167-1.1 and simplified checkver and autoupdate ungoogled-chromium: Update to version 148.0.7778.178-1.1, fix checkver, simplify autoupdate May 27, 2026
@z-Fng

z-Fng commented May 27, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

ungoogled-chromium

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng
z-Fng merged commit 5fd0677 into ScoopInstaller:master May 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ungoogled-chromium not updating to latest release

2 participants