ungoogled-chromium: Update to version 148.0.7778.178-1.1, fix checkver, simplify autoupdate#17879
Conversation
…kver and autoupdate
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ungoogled-chromium Scoop manifest: the package Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/ungoogled-chromium.json (1)
41-60: Please run the standard manifest checks locally before merge.Scoop’s contribution guide asks bucket contributors to test the manifest and confirm autoupdate, and the autoupdate wiki specifically recommends validating the generated
url,hash, andextract_dirwithcheckver.ps1. (github.com)Suggested commands
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App ungoogled-chromium -f .\bin\formatjson.ps1 -App ungoogled-chromium scoop install bucket/ungoogled-chromium.json -a 64bit scoop install bucket/ungoogled-chromium.json -a 32bit scoop install bucket/ungoogled-chromium.json -a arm64As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/ungoogled-chromium.json` around lines 41 - 60, Run the standard local manifest checks and update the PR with validation results: execute .\bin\checkver.ps1 -App ungoogled-chromium -f to validate the checkver output, then .\bin\formatjson.ps1 -App ungoogled-chromium to update the manifest; confirm the autoupdate block’s generated url, hash and extract_dir values for each architecture (64bit/32bit/arm64) are correct and that the URLs in the autoupdate "url" fields actually download the expected zip, and include the successful install test results (scoop install bucket/ungoogled-chromium.json -a 64bit/32bit/arm64) in the PR description so maintainers can see the manifest passed local validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/ungoogled-chromium.json`:
- Around line 42-43: The checkver.jsonpath currently ("$[?(@.prerelease ==
false)].tag_name") can match multiple releases; update the manifest's checkver
to deterministically pick a single tag by narrowing the JSONPath to select a
single element (e.g. index the filtered array like "$[?(@.prerelease ==
false)][0].tag_name") or alternatively add a "reverse": true or a "regex" to the
checkver block so the selected tag is explicit and reproducible; modify the
checkver entry in bucket/ungoogled-chromium.json accordingly.
---
Nitpick comments:
In `@bucket/ungoogled-chromium.json`:
- Around line 41-60: Run the standard local manifest checks and update the PR
with validation results: execute .\bin\checkver.ps1 -App ungoogled-chromium -f
to validate the checkver output, then .\bin\formatjson.ps1 -App
ungoogled-chromium to update the manifest; confirm the autoupdate block’s
generated url, hash and extract_dir values for each architecture
(64bit/32bit/arm64) are correct and that the URLs in the autoupdate "url" fields
actually download the expected zip, and include the successful install test
results (scoop install bucket/ungoogled-chromium.json -a 64bit/32bit/arm64) in
the PR description so maintainers can see the manifest passed local validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 90ee6abf-124e-4a0a-a96d-739bbc89f2c3
📒 Files selected for processing (1)
bucket/ungoogled-chromium.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. ungoogled-chromium
|
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Closes #17874
<manifest-name[@version]|chore>: <general summary of the pull request>