thonny: Update to version 5.0.0, fix portable asset rename#18321
Conversation
Upstream renamed the Windows portable zip from thonny-$version-windows-portable.zip to thonny-$version-windows-portable-x64.zip in 5.0.0. Update current URL/hash and autoupdate/checkver so the scheduled updater keeps working. Signed-off-by: Alex Chen <l46983284@gmail.com>
|
/verify |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Thonny bucket manifest is updated from version 4.1.7 to 5.0.0. The Windows portable download URL and hash are replaced, while the autoupdater regex now supports an optional Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. thonny
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/thonny.json (1)
2-24: 📐 Maintainability & Code Quality | 🔵 TrivialRun the standard Scoop validation before merging.
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App thonny -f .\bin\formatjson.ps1 -App thonny scoop install bucket/thonny.json -a 64bitAs per path instructions, validate version detection, formatting, and installation locally.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/thonny.json` around lines 2 - 24, Run the standard Scoop validation for the thonny manifest: enable debug mode and configure a GitHub token, then execute checkver.ps1 with force, formatjson.ps1, and a 64-bit installation of bucket/thonny.json. Resolve any version-detection, formatting, or installation issues before merging.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/thonny.json`:
- Around line 2-24: Run the standard Scoop validation for the thonny manifest:
enable debug mode and configure a GitHub token, then execute checkver.ps1 with
force, formatjson.ps1, and a 64-bit installation of bucket/thonny.json. Resolve
any version-detection, formatting, or installation issues before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: de9a2bc0-2269-4b20-9683-adeab0969b59
📒 Files selected for processing (1)
bucket/thonny.json
|
/verify |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/thonny.json (1)
22-32: 📐 Maintainability & Code Quality | 🔵 TrivialRun the manifest validation commands before submission.
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App thonny -f .\bin\formatjson.ps1 -App thonny scoop install bucket/thonny.json -a 64bitAs per path instructions, validate version detection, formatting, and 64-bit installation locally.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/thonny.json` around lines 22 - 32, Run the required manifest validation for thonny: enable Scoop debug mode, configure a GitHub token, execute checkver.ps1 with force and formatjson.ps1 for thonny, then verify 64-bit installation with scoop install. Fix any version-detection, formatting, or installation issues reported by these commands before submission.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/thonny.json`:
- Around line 22-32: Run the required manifest validation for thonny: enable
Scoop debug mode, configure a GitHub token, execute checkver.ps1 with force and
formatjson.ps1 for thonny, then verify 64-bit installation with scoop install.
Fix any version-detection, formatting, or installation issues reported by these
commands before submission.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9081c1bb-b684-4c01-b7bd-6530b49a7a66
📒 Files selected for processing (1)
bucket/thonny.json
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with thonny
|
fc8563f to
c4e30f7
Compare
|
/verify |
|
All changes look good. Wait for review from human collaborators. thonny
|
|
Thanks! |
Closes #18318
Upstream 5.0.0 renamed the Windows portable zip to
thonny-$version-windows-portable-x64.zip, so the old autoupdate pattern 404s. This PR bumps to 5.0.0, updates the hash from a full download of the new asset, and fixes checkver/autoupdate for the new name.<manifest-name[@version]|chore>: <general summary of the pull request>