-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
aws-sso-cli: Add version 2.1.0 #7007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All changes look good. Wait for review from human collaborators. aws-sso-cli
|
WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Assessment against linked issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/aws-sso-cli.json (1)
17-17: Optional: Make checkver explicit to the repo.Current
"checkver": "github"infers from homepage. Being explicit avoids surprises if homepage changes.- "checkver": "github", + "checkver": { + "github": "synfinatic/aws-sso-cli" + },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
bucket/aws-sso-cli.json(1 hunks)
🔇 Additional comments (3)
bucket/aws-sso-cli.json (3)
2-2: URLs and hashes match upstream v2.1.0 (released Sep 3, 2025).The 64-bit and 32-bit URLs resolve to the correct assets and the SHA-256 values match the hashes shown on the release page for v2.1.0. Looks good. (github.com)
Also applies to: 8-13
2-2: Align PR title/body with the manifest version.PR title/description mention 2.0.3, but the manifest targets 2.1.0 (released today, Sep 3, 2025). Please update the PR title/body accordingly to avoid confusion. (github.com)
5-5: Confirm SPDX license identifier accuracy.Repo shows “GPL-3.0 license” but it’s unclear if it’s “-only” or “-or-later.” Please confirm against LICENSE.md and adjust to the correct SPDX string if needed (GPL-3.0-only vs GPL-3.0-or-later). (github.com)
ef07ffc to
564d026
Compare
I fixed the nitpick; please review. |
564d026 to
55c9831
Compare
|
@HUMORCE PTAL 🙏 |
|
@Lutra-Fs PTAL at this too 🙏 |
|
Would this PR be accepted if I moved it to the ScoopInstaller/Extras repo? |
|
I have concerns about whether Windows Usage is Extremely Low The release statistics show:
Additional Concerns
Could you provide evidence of Windows-specific demand that justifies inclusion in Main bucket? |
|
@Lutra-Fs I can't argue with the stats. All I can say is that it's used by everyone where I work, so it would be really nice to be available via scoop. If it meets the criteria for the extras bucket then can we please move both issue and pull request there, otherwise I'll just close them here and be done with it. Either way, thanks for taking a look! |
|
/verify |
|
All changes look good. Wait for review from human collaborators. aws-sso-cli
|
|
Thank you for your contribution! |
Adds AWS SSO CLI.
Closes #7006
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit