Skip to content

Conversation

@gitfool
Copy link
Contributor

@gitfool gitfool commented Jul 30, 2025

Adds AWS SSO CLI.

Closes #7006

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Adds a Windows package for AWS SSO CLI v2.1.0 with 64-bit and 32-bit installers.
    • Includes description, homepage and license metadata for easier discovery.
    • Adds SHA-256 integrity checks for downloads.
    • Supports architecture-specific auto-update URLs to track new releases.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

aws-sso-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025

Walkthrough

Adds a new Scoop manifest bucket/aws-sso-cli.json for aws-sso-cli v2.1.0, including metadata, 32/64-bit download URLs with SHA-256 hashes, bin: aws-sso.exe, checkver: github, and per-architecture autoupdate URL templates using $version.

Changes

Cohort / File(s) Summary
New Scoop manifest
bucket/aws-sso-cli.json
Adds Windows package manifest for aws-sso-cli v2.1.0 with metadata (name, description, homepage, license), architecture-specific download URLs and SHA-256 hashes for 64bit/32bit, bin: aws-sso.exe, checkver: github, and autoupdate templates using $version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective Addressed Explanation
Provide Scoop manifest for aws-sso-cli (#7006)
Specify latest stable version and direct versioned download URL (#7006)
Non-GUI, English interface/docs, standard install pattern, and sufficient popularity (#7006)

Poem

I nibble bytes and polish keys,
A tiny manifest for ease.
Two arches built, the hashes set,
CLI ready — no regret.
Hop, fetch, install — enjoy the breeze. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title "aws-sso-cli: Add version 2.1.0" is concise, follows the repository's conventional format, and accurately summarizes the primary change (adding the aws-sso-cli manifest for version 2.1.0). It is specific enough for teammates scanning history.
Linked Issues Check ✅ Passed The manifest implements the linked issue #7006 requirements: it adds a non-GUI package for the requested stable version 2.1.0 with versioned release URLs, architecture-specific binaries, autoupdate patterns, hashes, a bin entry, homepage and license, and the PR metadata indicates the popularity criterion (550 stars) is met. These changes satisfy the coding-related objectives specified in the linked issue.
Out of Scope Changes Check ✅ Passed All changes are limited to a single new manifest file (bucket/aws-sso-cli.json) that directly implements the requested package; there are no unrelated file modifications or out-of-scope edits in the provided summary.
Description Check ✅ Passed The PR description includes a brief summary, a "Closes #7006" reference, and the required checklist items marked complete, aligning with the repository's template and providing sufficient context for the change. Additional non-critical details (such as explicit test notes) are optional.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 564d026 and 55c9831.

📒 Files selected for processing (1)
  • bucket/aws-sso-cli.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • bucket/aws-sso-cli.json

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gitfool gitfool changed the title aws-sso-cli: Add version 2.0.3 aws-sso-cli: Add version 2.1.0 Sep 3, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/aws-sso-cli.json (1)

17-17: Optional: Make checkver explicit to the repo.

Current "checkver": "github" infers from homepage. Being explicit avoids surprises if homepage changes.

-    "checkver": "github",
+    "checkver": {
+        "github": "synfinatic/aws-sso-cli"
+    },
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a4d1284 and 05d318e.

📒 Files selected for processing (1)
  • bucket/aws-sso-cli.json (1 hunks)
🔇 Additional comments (3)
bucket/aws-sso-cli.json (3)

2-2: URLs and hashes match upstream v2.1.0 (released Sep 3, 2025).

The 64-bit and 32-bit URLs resolve to the correct assets and the SHA-256 values match the hashes shown on the release page for v2.1.0. Looks good. (github.com)

Also applies to: 8-13


2-2: Align PR title/body with the manifest version.

PR title/description mention 2.0.3, but the manifest targets 2.1.0 (released today, Sep 3, 2025). Please update the PR title/body accordingly to avoid confusion. (github.com)


5-5: Confirm SPDX license identifier accuracy.

Repo shows “GPL-3.0 license” but it’s unclear if it’s “-only” or “-or-later.” Please confirm against LICENSE.md and adjust to the correct SPDX string if needed (GPL-3.0-only vs GPL-3.0-or-later). (github.com)

@gitfool gitfool force-pushed the aws-sso-cli branch 2 times, most recently from ef07ffc to 564d026 Compare September 3, 2025 21:11
@gitfool
Copy link
Contributor Author

gitfool commented Sep 3, 2025

Actionable comments posted: 1

🧹 Nitpick comments (1)

bucket/aws-sso-cli.json (1)> 17-17: Optional: Make checkver explicit to the repo.

Current "checkver": "github" infers from homepage. Being explicit avoids surprises if homepage changes.

-    "checkver": "github",
+    "checkver": {
+        "github": "synfinatic/aws-sso-cli"
+    },

I fixed the nitpick; please review.

@gitfool
Copy link
Contributor Author

gitfool commented Sep 17, 2025

@HUMORCE PTAL 🙏

@gitfool
Copy link
Contributor Author

gitfool commented Nov 18, 2025

@Lutra-Fs PTAL at this too 🙏

@gitfool
Copy link
Contributor Author

gitfool commented Dec 2, 2025

Would this PR be accepted if I moved it to the ScoopInstaller/Extras repo?

@Lutra-Fs
Copy link
Member

Lutra-Fs commented Dec 4, 2025

I have concerns about whether aws-sso-cli meets the "widely used" criteria for Scoop's Main bucket.

Windows Usage is Extremely Low

The release statistics show:

  • v2.1.0: 3,973 Linux downloads vs only 134 Windows downloads (~3%)
  • v1.17.0: 13,139 Linux downloads vs only 731 Windows downloads (~5%)
  • Total: 40,026 downloads across all versions, but Windows represents a small fraction

Additional Concerns

  • No commits in 3 months (last release: September 2025)
  • User base is overwhelmingly Linux/DevOps-focused

Could you provide evidence of Windows-specific demand that justifies inclusion in Main bucket?

@gitfool
Copy link
Contributor Author

gitfool commented Dec 4, 2025

@Lutra-Fs I can't argue with the stats. All I can say is that it's used by everyone where I work, so it would be really nice to be available via scoop. If it meets the criteria for the extras bucket then can we please move both issue and pull request there, otherwise I'll just close them here and be done with it. Either way, thanks for taking a look!

@Lutra-Fs
Copy link
Member

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

aws-sso-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@Lutra-Fs Lutra-Fs merged commit 7925876 into ScoopInstaller:master Jan 5, 2026
3 checks passed
@Lutra-Fs
Copy link
Member

Lutra-Fs commented Jan 5, 2026

Thank you for your contribution!

@gitfool gitfool deleted the aws-sso-cli branch January 5, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: aws-sso-cli

2 participants