-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
winmemorycleaner: Add version 3.0.2 #7152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winmemorycleaner: Add version 3.0.2 #7152
Conversation
WalkthroughAdds a new Scoop manifest for WinMemoryCleaner (version 3.0.2) including metadata, download URL with SHA256, install targets (bin and shortcut), GitHub-based version check, and an autoupdate template. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. winmemorycleaner
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/winmemorycleaner.json (1)
14-15: Optional: add a user note about admin rights.Upstream states the app needs administrator privileges; a note can reduce confusion for Scoop users. (github.com)
], - "checkver": "github", + "notes": "WinMemoryCleaner requires administrator privileges to run and may prompt for UAC elevation.", + "checkver": "github",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/winmemorycleaner.json(1 hunks)
🔇 Additional comments (4)
bucket/winmemorycleaner.json (4)
8-14: Keepingbinis appropriate (console mode supported).The app supports command-line arguments; exposing the exe via
binis useful. Shortcut looks fine. (github.com)
15-18: checkver/autoupdate look good for GitHub tags.This will track the latest stable tag and expand
$versioncorrectly.
2-7: Verify SHA256 for WinMemoryCleaner 3.0.2 releaseVersion and download URL in bucket/winmemorycleaner.json match upstream 3.0.2; the sandbox couldn't compute the release binary's SHA256 — confirm the "hash" field equals the SHA256 of the downloaded binary.
Location: bucket/winmemorycleaner.json (lines 2–7)
Windows (PowerShell):
Invoke-WebRequest 'https://github.com/IgorMundstein/WinMemoryCleaner/releases/download/3.0.2/WinMemoryCleaner.exe' -OutFile WinMemoryCleaner-3.0.2.exe; (Get-FileHash WinMemoryCleaner-3.0.2.exe -Algorithm SHA256).HashLinux/macOS:
curl -sL 'https://github.com/IgorMundstein/WinMemoryCleaner/releases/download/3.0.2/WinMemoryCleaner.exe' -o WinMemoryCleaner-3.0.2.exe && shasum -a 256 WinMemoryCleaner-3.0.2.exe | awk '{print $1}'
6-7: Do not mark this asset as 64‑bit — it is 32‑bit (PE32).Downloaded binary reports PE header magic 0x10B (PE32) and SHA256 = 5dcaa33af0034ac8f40c8109d5c46858de4f8ed53b9989e7a8cb59ed7cb4dc6d (matches manifest). If you want architecture-scoped fields, use a "32bit" key and mirror autoupdate under that key. Applies to bucket/winmemorycleaner.json lines 6-7 and 15-18.
Likely an incorrect or invalid review comment.
| "version": "3.0.2", | ||
| "description": "Portable RAM cleaner using native Windows features to optimize memory.", | ||
| "homepage": "https://github.com/IgorMundstein/WinMemoryCleaner", | ||
| "license": "GPL-3.0-only", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm SPDX license identifier accuracy (“-only” vs “-or-later”).
Repo indicates GPL-3.0, but whether it’s “only” or “or-later” depends on LICENSE text. Ensure this matches upstream. (github.com)
If it mentions “any later version,” switch to GPL-3.0-or-later.
🏁 Script executed:
#!/usr/bin/env bash
curl -fsSL https://raw.githubusercontent.com/IgorMundstein/WinMemoryCleaner/main/LICENSE | rg -n 'any later version|either version 3'Length of output: 254
Update SPDX license identifier to GPL-3.0-or-later
LICENSE contains "either version 3 of the License, or (at your option) any later version" (LICENSE lines 639–640); change bucket/winmemorycleaner.json (line 5) from "GPL-3.0-only" to "GPL-3.0-or-later".
🤖 Prompt for AI Agents
In bucket/winmemorycleaner.json around line 5, the SPDX license identifier is
set to "GPL-3.0-only" but the project's LICENSE states "either version 3 of the
License, or (at your option) any later version"; update the identifier to
"GPL-3.0-or-later" to reflect the correct permissive version range and save the
JSON file.
Adds the initial Scoop manifest for WinMemoryCleaner 3.0.2.
Portable RAM cleaner using native Windows features to optimize memory.
No related issue (new manifest)
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit